You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/12 18:37:30 UTC
[GitHub] [kafka] milindmantri opened a new pull request, #12152: MINOR: Fix DSL typo in streams docs
milindmantri opened a new pull request, #12152:
URL: https://github.com/apache/kafka/pull/12152
Minor typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] milindmantri commented on pull request #12152: MINOR: Fix DSL typo in streams docs
Posted by GitBox <gi...@apache.org>.
milindmantri commented on PR #12152:
URL: https://github.com/apache/kafka/pull/12152#issuecomment-1128629108
> Thanks for the PR, @milindmantri !
>
> LGTM!
>
> Could you open a PR with the same change against https://github.com/apache/kafka-site in https://github.com/apache/kafka-site/blob/322c407ca9786962480d35ce3b9fe58c8e30f8aa/32/streams/developer-guide/dsl-topology-naming.html so that the AK website is updated before the next release?
Indeed. Will do :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] milindmantri commented on pull request #12152: MINOR: Fix DSL typo in streams docs
Posted by GitBox <gi...@apache.org>.
milindmantri commented on PR #12152:
URL: https://github.com/apache/kafka/pull/12152#issuecomment-1125774388
cc: @bbejeck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] milindmantri commented on pull request #12152: MINOR: Fix DSL typo in streams docs
Posted by GitBox <gi...@apache.org>.
milindmantri commented on PR #12152:
URL: https://github.com/apache/kafka/pull/12152#issuecomment-1128646978
@cadonna, thanks for the review!
I'm thinking if it is required to duplicate changes in both places, is it possible to automate this? What would it take to maintain consistency across?
I can work on it if it can save some work for any docs related changes.
I may be missing some pointers on the docs change related process here, sorry for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12152: MINOR: Fix DSL typo in streams docs
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12152:
URL: https://github.com/apache/kafka/pull/12152#issuecomment-1128659599
The issue is that some doc changes are specific to the next release and should only exist in apache/kafka until the release is released. During the release those changes are then copied to apache/kafka-site and consequently shown on the AK webiste. Other changes -- like typos -- can immediately go to both repos because they do not depend on the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] milindmantri commented on pull request #12152: MINOR: Fix DSL typo in streams docs
Posted by GitBox <gi...@apache.org>.
milindmantri commented on PR #12152:
URL: https://github.com/apache/kafka/pull/12152#issuecomment-1132547512
@cadonna, I looked into this. My initial idea was that adding a `docs-typo`-like label to a PR would trigger (after merge) a workflow/action on `kafka-site` that creates a PR there. I'm not sure about the directory mapping from `apache/kafka` to `apache/kafka-site`, but this can be explored.
Does this resonate with you? Can you think of another way or how this can be improved?
Is this even worth exploring further, considering the number/rate of PRs that are for docs related typos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12152: MINOR: Fix DSL typo in streams docs
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12152:
URL: https://github.com/apache/kafka/pull/12152#issuecomment-1132573699
Thanks for the idea!
To get more information about the directory mapping you can consult the release process wiki: https://cwiki.apache.org/confluence/display/KAFKA/Release+Process . There are two parts that describe how docs are released, one is section "Website update process" and the other is the item "Update the website:" under section "After the vote passes".
If you have tested your idea, feel free to propose it on the dev mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #12152: MINOR: Fix DSL typo in streams docs
Posted by GitBox <gi...@apache.org>.
cadonna merged PR #12152:
URL: https://github.com/apache/kafka/pull/12152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org