You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2018/08/03 20:42:21 UTC

[GitHub] spark pull request #21919: [SPARK-24933][SS] Report numOutputRows in SinkPro...

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21919#discussion_r207662087
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/streaming/StreamWriterCommitProgress.java ---
    @@ -0,0 +1,31 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.sql.sources.v2.writer.streaming;
    +
    +import org.apache.spark.annotation.InterfaceStability;
    +import org.apache.spark.sql.sources.v2.writer.WriterCommitMessage;
    +
    +import java.io.Serializable;
    +
    +/**
    + * Sink progress information collected from {@link WriterCommitMessage}.
    + */
    +@InterfaceStability.Evolving
    +public interface StreamWriterCommitProgress extends Serializable {
    --- End diff --
    
    Why this is a public API? This is just created and consumed inside Spark.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org