You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2013/03/17 21:40:14 UTC

Review Request: Social Data Updates for 2.0

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9990/
-----------------------------------------------------------

Review request for shindig.


Description
-------

Modification to social data model reflecting the proposed changes in the spec


This addresses bug SHINDIG-1539.
    https://issues.apache.org/jira/browse/SHINDIG-1539


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/AddressDb.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/NameDb.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/PersonDb.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/AddressImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/NameImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/PersonImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Address.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Name.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Person.java 1455767 

Diff: https://reviews.apache.org/r/9990/diff/


Testing
-------


Thanks,

Ryan Baxter


Re: Review Request: Social Data Updates for 2.0

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9990/
-----------------------------------------------------------

(Updated March 18, 2013, 6:37 p.m.)


Review request for shindig.


Description
-------

Modification to social data model reflecting the proposed changes in the spec


This addresses bug SHINDIG-1539.
    https://issues.apache.org/jira/browse/SHINDIG-1539


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/AddressDb.java 1457906 
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/NameDb.java 1457906 
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/OrganizationDb.java 1457906 
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/PersonDb.java 1457906 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/AddressImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/NameImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/OrganizationImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/PersonImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Address.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Name.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Person.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/testschema1.xml 1455767 

Diff: https://reviews.apache.org/r/9990/diff/


Testing
-------


Thanks,

Ryan Baxter


Re: Review Request: Social Data Updates for 2.0

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9990/
-----------------------------------------------------------

(Updated March 18, 2013, 4:12 p.m.)


Review request for shindig.


Changes
-------

Merged the changes from SHINDIG-1878 into this patch as well since they were mostly duplicates of each other.

Most of the changes in the XSD are formatting changes to eliminate tabs.  I only had to make one actual change in that file, and that was changing the connected attribute to have the proper type.


Description
-------

Modification to social data model reflecting the proposed changes in the spec


This addresses bug SHINDIG-1539.
    https://issues.apache.org/jira/browse/SHINDIG-1539


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/AddressDb.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/NameDb.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/PersonDb.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/AddressImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/NameImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/OrganizationImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/PersonImpl.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Address.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Name.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Person.java 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd 1455767 
  http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/testschema1.xml 1455767 

Diff: https://reviews.apache.org/r/9990/diff/


Testing
-------


Thanks,

Ryan Baxter