You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/27 02:57:53 UTC
[GitHub] [flink] zhoulii commented on a diff in pull request #20072: [FLINK-28136][runtime] Implement ExecutionTimeBasedSlowTaskDetector
zhoulii commented on code in PR #20072:
URL: https://github.com/apache/flink/pull/20072#discussion_r906918702
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java:
##########
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.slowtaskdetector;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.SlowTaskDetectorOptions;
+import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutor;
+import org.apache.flink.runtime.execution.ExecutionState;
+import org.apache.flink.runtime.executiongraph.Execution;
+import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
+import org.apache.flink.runtime.executiongraph.ExecutionGraph;
+import org.apache.flink.runtime.executiongraph.ExecutionJobVertex;
+import org.apache.flink.runtime.executiongraph.ExecutionVertex;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+import org.apache.flink.util.IterableUtils;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.util.Preconditions.checkState;
+
+/** The slow task detector which detects slow tasks based on their execution time. */
+public class ExecutionTimeBasedSlowTaskDetector implements SlowTaskDetector {
+
+ private final long checkIntervalMillis;
+
+ private final long baselineLowerBoundMillis;
+
+ private final double baselineRatio;
+
+ private final double baselineMultiplier;
+
+ private ScheduledFuture<?> scheduledDetectionFuture;
+
+ public ExecutionTimeBasedSlowTaskDetector(Configuration configuration) {
+ this.checkIntervalMillis =
+ configuration.get(SlowTaskDetectorOptions.CHECK_INTERVAL).toMillis();
+ this.baselineLowerBoundMillis =
+ configuration
+ .get(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_LOWER_BOUND)
+ .toMillis();
+ this.baselineRatio =
+ configuration.getDouble(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_RATIO);
+ this.baselineMultiplier =
+ configuration.getDouble(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_MULTIPLIER);
+ }
+
+ @Override
+ public void start(
+ final ExecutionGraph executionGraph,
+ final SlowTaskDetectorListener listener,
+ final ComponentMainThreadExecutor mainThreadExecutor) {
+ scheduleTask(executionGraph, listener, mainThreadExecutor);
+ }
+
+ /** Schedule periodical slow task detection. */
+ private void scheduleTask(
+ final ExecutionGraph executionGraph,
+ final SlowTaskDetectorListener listener,
+ final ComponentMainThreadExecutor mainThreadExecutor) {
+ this.scheduledDetectionFuture =
+ mainThreadExecutor.schedule(
+ () -> {
+ listener.notifySlowTasks(findSlowTasks(executionGraph));
+ scheduleTask(executionGraph, listener, mainThreadExecutor);
+ },
+ checkIntervalMillis,
+ TimeUnit.MILLISECONDS);
+ }
+
+ /**
+ * Given that the parallelism is N and the ratio is R, define T as the median of the first N*R
+ * finished tasks' execution time. The baseline will be T*M, where M is the multiplier. A task
+ * will be identified as slow if its execution time is longer than the baseline.
+ */
+ @VisibleForTesting
+ Map<ExecutionVertexID, Collection<ExecutionAttemptID>> findSlowTasks(
+ final ExecutionGraph executionGraph) {
+ final long currentTimeMillis = System.currentTimeMillis();
+
+ final Map<ExecutionVertexID, Collection<ExecutionAttemptID>> slowTasks = new HashMap<>();
+
+ final List<ExecutionJobVertex> jobVerticesToCheck = getJobVerticesToCheck(executionGraph);
+
+ for (ExecutionJobVertex ejv : jobVerticesToCheck) {
+ final long baseline = getBaseline(ejv, currentTimeMillis);
+
+ for (ExecutionVertex ev : ejv.getTaskVertices()) {
+ if (ev.getExecutionState().isTerminal()) {
+ continue;
+ }
+
+ final List<ExecutionAttemptID> slowExecutions =
+ findExecutionsExceedingBaseline(
+ ev.getCurrentExecutionAttempts(), baseline, currentTimeMillis);
+
+ if (!slowExecutions.isEmpty()) {
+ slowTasks.put(ev.getID(), slowExecutions);
+ }
+ }
+ }
+
+ return slowTasks;
+ }
+
+ private List<ExecutionJobVertex> getJobVerticesToCheck(final ExecutionGraph executionGraph) {
+ return IterableUtils.toStream(executionGraph.getVerticesTopologically())
+ .filter(ejv -> ejv.isInitialized())
+ .filter(ejv -> ejv.getAggregateState() != ExecutionState.FINISHED)
+ .filter(ejv -> getFinishedRatio(ejv) >= baselineRatio)
+ .collect(Collectors.toList());
+ }
+
+ private double getFinishedRatio(final ExecutionJobVertex executionJobVertex) {
+ checkState(executionJobVertex.getTaskVertices().length > 0);
+ long finishedCount =
+ Arrays.stream(executionJobVertex.getTaskVertices())
+ .filter(ev -> ev.getExecutionState() == ExecutionState.FINISHED)
+ .count();
+ return Double.valueOf(finishedCount) / executionJobVertex.getTaskVertices().length;
Review Comment:
```suggestion
return (double) finishedCount / executionJobVertex.getTaskVertices().length;
```
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java:
##########
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.slowtaskdetector;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.SlowTaskDetectorOptions;
+import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutor;
+import org.apache.flink.runtime.execution.ExecutionState;
+import org.apache.flink.runtime.executiongraph.Execution;
+import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
+import org.apache.flink.runtime.executiongraph.ExecutionGraph;
+import org.apache.flink.runtime.executiongraph.ExecutionJobVertex;
+import org.apache.flink.runtime.executiongraph.ExecutionVertex;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+import org.apache.flink.util.IterableUtils;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.util.Preconditions.checkState;
+
+/** The slow task detector which detects slow tasks based on their execution time. */
+public class ExecutionTimeBasedSlowTaskDetector implements SlowTaskDetector {
+
+ private final long checkIntervalMillis;
+
+ private final long baselineLowerBoundMillis;
+
+ private final double baselineRatio;
+
+ private final double baselineMultiplier;
+
+ private ScheduledFuture<?> scheduledDetectionFuture;
+
+ public ExecutionTimeBasedSlowTaskDetector(Configuration configuration) {
+ this.checkIntervalMillis =
+ configuration.get(SlowTaskDetectorOptions.CHECK_INTERVAL).toMillis();
+ this.baselineLowerBoundMillis =
+ configuration
+ .get(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_LOWER_BOUND)
+ .toMillis();
+ this.baselineRatio =
+ configuration.getDouble(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_RATIO);
+ this.baselineMultiplier =
+ configuration.getDouble(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_MULTIPLIER);
Review Comment:
we should check the validity of parameters
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java:
##########
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.slowtaskdetector;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.SlowTaskDetectorOptions;
+import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutor;
+import org.apache.flink.runtime.execution.ExecutionState;
+import org.apache.flink.runtime.executiongraph.Execution;
+import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
+import org.apache.flink.runtime.executiongraph.ExecutionGraph;
+import org.apache.flink.runtime.executiongraph.ExecutionJobVertex;
+import org.apache.flink.runtime.executiongraph.ExecutionVertex;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+import org.apache.flink.util.IterableUtils;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.util.Preconditions.checkState;
+
+/** The slow task detector which detects slow tasks based on their execution time. */
+public class ExecutionTimeBasedSlowTaskDetector implements SlowTaskDetector {
+
+ private final long checkIntervalMillis;
+
+ private final long baselineLowerBoundMillis;
+
+ private final double baselineRatio;
+
+ private final double baselineMultiplier;
+
+ private ScheduledFuture<?> scheduledDetectionFuture;
+
+ public ExecutionTimeBasedSlowTaskDetector(Configuration configuration) {
+ this.checkIntervalMillis =
+ configuration.get(SlowTaskDetectorOptions.CHECK_INTERVAL).toMillis();
+ this.baselineLowerBoundMillis =
+ configuration
+ .get(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_LOWER_BOUND)
+ .toMillis();
+ this.baselineRatio =
+ configuration.getDouble(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_RATIO);
+ this.baselineMultiplier =
+ configuration.getDouble(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_MULTIPLIER);
+ }
+
+ @Override
+ public void start(
+ final ExecutionGraph executionGraph,
+ final SlowTaskDetectorListener listener,
+ final ComponentMainThreadExecutor mainThreadExecutor) {
+ scheduleTask(executionGraph, listener, mainThreadExecutor);
+ }
+
+ /** Schedule periodical slow task detection. */
+ private void scheduleTask(
+ final ExecutionGraph executionGraph,
+ final SlowTaskDetectorListener listener,
+ final ComponentMainThreadExecutor mainThreadExecutor) {
+ this.scheduledDetectionFuture =
+ mainThreadExecutor.schedule(
+ () -> {
+ listener.notifySlowTasks(findSlowTasks(executionGraph));
+ scheduleTask(executionGraph, listener, mainThreadExecutor);
+ },
+ checkIntervalMillis,
+ TimeUnit.MILLISECONDS);
+ }
+
+ /**
+ * Given that the parallelism is N and the ratio is R, define T as the median of the first N*R
+ * finished tasks' execution time. The baseline will be T*M, where M is the multiplier. A task
+ * will be identified as slow if its execution time is longer than the baseline.
+ */
+ @VisibleForTesting
+ Map<ExecutionVertexID, Collection<ExecutionAttemptID>> findSlowTasks(
+ final ExecutionGraph executionGraph) {
+ final long currentTimeMillis = System.currentTimeMillis();
+
+ final Map<ExecutionVertexID, Collection<ExecutionAttemptID>> slowTasks = new HashMap<>();
+
+ final List<ExecutionJobVertex> jobVerticesToCheck = getJobVerticesToCheck(executionGraph);
+
+ for (ExecutionJobVertex ejv : jobVerticesToCheck) {
+ final long baseline = getBaseline(ejv, currentTimeMillis);
+
+ for (ExecutionVertex ev : ejv.getTaskVertices()) {
+ if (ev.getExecutionState().isTerminal()) {
+ continue;
+ }
+
+ final List<ExecutionAttemptID> slowExecutions =
+ findExecutionsExceedingBaseline(
+ ev.getCurrentExecutionAttempts(), baseline, currentTimeMillis);
+
+ if (!slowExecutions.isEmpty()) {
+ slowTasks.put(ev.getID(), slowExecutions);
+ }
+ }
+ }
+
+ return slowTasks;
+ }
+
+ private List<ExecutionJobVertex> getJobVerticesToCheck(final ExecutionGraph executionGraph) {
+ return IterableUtils.toStream(executionGraph.getVerticesTopologically())
+ .filter(ejv -> ejv.isInitialized())
Review Comment:
```suggestion
.filter(ExecutionJobVertex::isInitialized)
```
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetectorTest.java:
##########
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.slowtaskdetector;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.SlowTaskDetectorOptions;
+import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutorServiceAdapter;
+import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
+import org.apache.flink.runtime.executiongraph.ExecutionGraph;
+import org.apache.flink.runtime.executiongraph.ExecutionGraphTestUtils;
+import org.apache.flink.runtime.executiongraph.ExecutionVertex;
+import org.apache.flink.runtime.io.network.partition.ResultPartitionType;
+import org.apache.flink.runtime.jobgraph.DistributionPattern;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.jobgraph.JobGraphTestUtils;
+import org.apache.flink.runtime.jobgraph.JobVertex;
+import org.apache.flink.runtime.scheduler.SchedulerBase;
+import org.apache.flink.runtime.scheduler.SchedulerTestingUtils;
+import org.apache.flink.runtime.scheduler.adaptivebatch.AdaptiveBatchSchedulerTestUtils;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+import org.apache.flink.runtime.testtasks.NoOpInvokable;
+import org.apache.flink.testutils.TestingUtils;
+import org.apache.flink.testutils.executor.TestExecutorResource;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.ClassRule;
+import org.junit.Test;
+
+import java.time.Duration;
+import java.util.Collection;
+import java.util.Map;
+import java.util.concurrent.ScheduledExecutorService;
+
+import static org.apache.flink.runtime.executiongraph.ExecutionGraphTestUtils.createNoOpVertex;
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+
+/** Tests for {@link ExecutionTimeBasedSlowTaskDetector}. */
+public class ExecutionTimeBasedSlowTaskDetectorTest extends TestLogger {
Review Comment:
[FYI](https://flink.apache.org/contributing/code-style-and-quality-common.html#testing) , Flink community is moving codebase to [JUnit 5](https://junit.org/junit5/docs/current/user-guide/) and [AssertJ](https://assertj.github.io/doc/) as testing framework and assertions library of choice, Would you mind migrate this ut to be based on junit5?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java:
##########
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.slowtaskdetector;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.SlowTaskDetectorOptions;
+import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutor;
+import org.apache.flink.runtime.execution.ExecutionState;
+import org.apache.flink.runtime.executiongraph.Execution;
+import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
+import org.apache.flink.runtime.executiongraph.ExecutionGraph;
+import org.apache.flink.runtime.executiongraph.ExecutionJobVertex;
+import org.apache.flink.runtime.executiongraph.ExecutionVertex;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+import org.apache.flink.util.IterableUtils;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.util.Preconditions.checkState;
+
+/** The slow task detector which detects slow tasks based on their execution time. */
+public class ExecutionTimeBasedSlowTaskDetector implements SlowTaskDetector {
+
+ private final long checkIntervalMillis;
+
+ private final long baselineLowerBoundMillis;
+
+ private final double baselineRatio;
+
+ private final double baselineMultiplier;
+
+ private ScheduledFuture<?> scheduledDetectionFuture;
+
+ public ExecutionTimeBasedSlowTaskDetector(Configuration configuration) {
+ this.checkIntervalMillis =
+ configuration.get(SlowTaskDetectorOptions.CHECK_INTERVAL).toMillis();
+ this.baselineLowerBoundMillis =
+ configuration
+ .get(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_LOWER_BOUND)
+ .toMillis();
+ this.baselineRatio =
+ configuration.getDouble(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_RATIO);
+ this.baselineMultiplier =
+ configuration.getDouble(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_MULTIPLIER);
+ }
+
+ @Override
+ public void start(
+ final ExecutionGraph executionGraph,
+ final SlowTaskDetectorListener listener,
+ final ComponentMainThreadExecutor mainThreadExecutor) {
+ scheduleTask(executionGraph, listener, mainThreadExecutor);
+ }
+
+ /** Schedule periodical slow task detection. */
+ private void scheduleTask(
+ final ExecutionGraph executionGraph,
+ final SlowTaskDetectorListener listener,
+ final ComponentMainThreadExecutor mainThreadExecutor) {
+ this.scheduledDetectionFuture =
+ mainThreadExecutor.schedule(
+ () -> {
+ listener.notifySlowTasks(findSlowTasks(executionGraph));
+ scheduleTask(executionGraph, listener, mainThreadExecutor);
+ },
+ checkIntervalMillis,
+ TimeUnit.MILLISECONDS);
+ }
+
+ /**
+ * Given that the parallelism is N and the ratio is R, define T as the median of the first N*R
+ * finished tasks' execution time. The baseline will be T*M, where M is the multiplier. A task
+ * will be identified as slow if its execution time is longer than the baseline.
+ */
+ @VisibleForTesting
+ Map<ExecutionVertexID, Collection<ExecutionAttemptID>> findSlowTasks(
+ final ExecutionGraph executionGraph) {
+ final long currentTimeMillis = System.currentTimeMillis();
+
+ final Map<ExecutionVertexID, Collection<ExecutionAttemptID>> slowTasks = new HashMap<>();
+
+ final List<ExecutionJobVertex> jobVerticesToCheck = getJobVerticesToCheck(executionGraph);
+
+ for (ExecutionJobVertex ejv : jobVerticesToCheck) {
+ final long baseline = getBaseline(ejv, currentTimeMillis);
+
+ for (ExecutionVertex ev : ejv.getTaskVertices()) {
+ if (ev.getExecutionState().isTerminal()) {
+ continue;
+ }
+
+ final List<ExecutionAttemptID> slowExecutions =
+ findExecutionsExceedingBaseline(
+ ev.getCurrentExecutionAttempts(), baseline, currentTimeMillis);
+
+ if (!slowExecutions.isEmpty()) {
+ slowTasks.put(ev.getID(), slowExecutions);
+ }
+ }
+ }
+
+ return slowTasks;
+ }
+
+ private List<ExecutionJobVertex> getJobVerticesToCheck(final ExecutionGraph executionGraph) {
+ return IterableUtils.toStream(executionGraph.getVerticesTopologically())
+ .filter(ejv -> ejv.isInitialized())
+ .filter(ejv -> ejv.getAggregateState() != ExecutionState.FINISHED)
+ .filter(ejv -> getFinishedRatio(ejv) >= baselineRatio)
+ .collect(Collectors.toList());
+ }
+
+ private double getFinishedRatio(final ExecutionJobVertex executionJobVertex) {
+ checkState(executionJobVertex.getTaskVertices().length > 0);
+ long finishedCount =
+ Arrays.stream(executionJobVertex.getTaskVertices())
+ .filter(ev -> ev.getExecutionState() == ExecutionState.FINISHED)
+ .count();
+ return Double.valueOf(finishedCount) / executionJobVertex.getTaskVertices().length;
+ }
+
+ private long getBaseline(
+ final ExecutionJobVertex executionJobVertex, final long currentTimeMillis) {
+ final long executionTimeMedian =
+ calculateFinishedTaskExecutionTimeMedian(executionJobVertex, currentTimeMillis);
+ return (long) Math.max(baselineLowerBoundMillis, executionTimeMedian * baselineMultiplier);
+ }
+
+ private long calculateFinishedTaskExecutionTimeMedian(
+ final ExecutionJobVertex executionJobVertex, final long currentTime) {
+
+ final int baselineExecutionCount =
+ Double.valueOf(Math.round(executionJobVertex.getParallelism() * baselineRatio))
+ .intValue();
+
+ if (baselineExecutionCount == 0) {
+ return 0;
+ }
+
+ final List<Execution> finishedExecutions =
+ Arrays.stream(executionJobVertex.getTaskVertices())
+ .flatMap(ev -> ev.getCurrentExecutionAttempts().stream())
+ .filter(e -> e.getState() == ExecutionState.FINISHED)
+ .collect(Collectors.toList());
+
+ checkState(finishedExecutions.size() >= baselineExecutionCount);
+
+ final List<Long> firstFinishedExecutions =
+ finishedExecutions.stream()
+ .map(e -> getExecutionTime(e, currentTime))
+ .sorted()
+ .limit(baselineExecutionCount)
+ .collect(Collectors.toList());
+
+ return firstFinishedExecutions.get(baselineExecutionCount / 2);
+ }
+
+ private List<ExecutionAttemptID> findExecutionsExceedingBaseline(
+ Collection<Execution> executions, long baseline, long currentTimeMillis) {
+ return executions.stream()
+ .filter(e -> !e.getState().isTerminal() && e.getState() != ExecutionState.CANCELING)
+ .filter(e -> getExecutionTime(e, currentTimeMillis) >= baseline)
+ .map(Execution::getAttemptId)
+ .collect(Collectors.toList());
+ }
+
+ private long getExecutionTime(final Execution execution, final long currentTime) {
Review Comment:
Maybe, making `currentTime` as a parameter is not nessary, we can make it inside the method body.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java:
##########
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.runtime.scheduler.slowtaskdetector;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.SlowTaskDetectorOptions;
+import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutor;
+import org.apache.flink.runtime.execution.ExecutionState;
+import org.apache.flink.runtime.executiongraph.Execution;
+import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
+import org.apache.flink.runtime.executiongraph.ExecutionGraph;
+import org.apache.flink.runtime.executiongraph.ExecutionJobVertex;
+import org.apache.flink.runtime.executiongraph.ExecutionVertex;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+import org.apache.flink.util.IterableUtils;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.util.Preconditions.checkState;
+
+/** The slow task detector which detects slow tasks based on their execution time. */
+public class ExecutionTimeBasedSlowTaskDetector implements SlowTaskDetector {
+
+ private final long checkIntervalMillis;
+
+ private final long baselineLowerBoundMillis;
+
+ private final double baselineRatio;
+
+ private final double baselineMultiplier;
+
+ private ScheduledFuture<?> scheduledDetectionFuture;
+
+ public ExecutionTimeBasedSlowTaskDetector(Configuration configuration) {
+ this.checkIntervalMillis =
+ configuration.get(SlowTaskDetectorOptions.CHECK_INTERVAL).toMillis();
+ this.baselineLowerBoundMillis =
+ configuration
+ .get(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_LOWER_BOUND)
+ .toMillis();
+ this.baselineRatio =
+ configuration.getDouble(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_RATIO);
+ this.baselineMultiplier =
+ configuration.getDouble(SlowTaskDetectorOptions.EXECUTION_TIME_BASELINE_MULTIPLIER);
+ }
+
+ @Override
+ public void start(
+ final ExecutionGraph executionGraph,
+ final SlowTaskDetectorListener listener,
+ final ComponentMainThreadExecutor mainThreadExecutor) {
+ scheduleTask(executionGraph, listener, mainThreadExecutor);
+ }
+
+ /** Schedule periodical slow task detection. */
+ private void scheduleTask(
+ final ExecutionGraph executionGraph,
+ final SlowTaskDetectorListener listener,
+ final ComponentMainThreadExecutor mainThreadExecutor) {
+ this.scheduledDetectionFuture =
+ mainThreadExecutor.schedule(
+ () -> {
+ listener.notifySlowTasks(findSlowTasks(executionGraph));
+ scheduleTask(executionGraph, listener, mainThreadExecutor);
+ },
+ checkIntervalMillis,
+ TimeUnit.MILLISECONDS);
+ }
+
+ /**
+ * Given that the parallelism is N and the ratio is R, define T as the median of the first N*R
+ * finished tasks' execution time. The baseline will be T*M, where M is the multiplier. A task
+ * will be identified as slow if its execution time is longer than the baseline.
+ */
+ @VisibleForTesting
+ Map<ExecutionVertexID, Collection<ExecutionAttemptID>> findSlowTasks(
+ final ExecutionGraph executionGraph) {
+ final long currentTimeMillis = System.currentTimeMillis();
+
+ final Map<ExecutionVertexID, Collection<ExecutionAttemptID>> slowTasks = new HashMap<>();
+
+ final List<ExecutionJobVertex> jobVerticesToCheck = getJobVerticesToCheck(executionGraph);
+
+ for (ExecutionJobVertex ejv : jobVerticesToCheck) {
+ final long baseline = getBaseline(ejv, currentTimeMillis);
+
+ for (ExecutionVertex ev : ejv.getTaskVertices()) {
+ if (ev.getExecutionState().isTerminal()) {
+ continue;
+ }
+
+ final List<ExecutionAttemptID> slowExecutions =
+ findExecutionsExceedingBaseline(
+ ev.getCurrentExecutionAttempts(), baseline, currentTimeMillis);
+
+ if (!slowExecutions.isEmpty()) {
+ slowTasks.put(ev.getID(), slowExecutions);
+ }
+ }
+ }
+
+ return slowTasks;
+ }
+
+ private List<ExecutionJobVertex> getJobVerticesToCheck(final ExecutionGraph executionGraph) {
+ return IterableUtils.toStream(executionGraph.getVerticesTopologically())
+ .filter(ejv -> ejv.isInitialized())
+ .filter(ejv -> ejv.getAggregateState() != ExecutionState.FINISHED)
Review Comment:
Maybe, We can use `ejv -> !ejv.getAggregateState().isTerminal()` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org