Re: [vote] release 1.4.2

[nino martinez wael <ni...@gmail.com>]

This is correct Juergen. I've playede around this a couple of years back.
And was exactly what I discovered. For me the default are inherieted from
the container and that are cp1252, at least in eclipse.. I would believe
that eclipse are grabbing the same way as tomcat maven etc.. You actually
have to configure maven to use UTF for example other wise it will also grab
code page from os etc....

2009/9/28 Juergen Donnerstag <ju...@gmail.com>

> I think SUNs default is the char encoding configured with the OS or
> env vars. If you don't explicitly provide a char encoding, that is
> what is used. I don't think we should assume ISO 8859-1 or any other
> to be the default, but use what is configured with the OS/env.
>
> -Juergen
>
> On Mon, Sep 28, 2009 at 1:49 PM, Robin Sander <ro...@gmx.net>
> wrote:
> >
> > I think the default should remain ISO 8859-1 because otherwise 1.4.2
> > wouldn't be
> > backward compatible.
> > And isn't the Java default for property files ISO 8859-1so any deveoper
> and
> > most IDEs
> > would assume this encoding?
> >
> > robin.
> >
> >
> > On Sep 28, 2009, at 11:42, Johan Compagner wrote:
> >
> >> -1 then yes
> >> that shouldnt be hardcoded but a property in our settings.
> >>
> >>
> >> On Mon, Sep 28, 2009 at 11:02, Ernesto Reinaldo Barreiro
> >> <reiern70@gmail.com
> >>>
> >>> wrote:
> >>
> >>>> [ X] No, don't release it and here is why...
> >>>>
> >>>
> >>> After upgrading to 1.4.2 all my ISO-8859-1 encoded property files fail
> to
> >>> work. I haven't look into it in detail but I guess this is related to
> >>> * [WICKET-2451] - Add ability to load UTF-8 encoded properties not
> >>> in XML format.
> >>>
> >>>
> >>> I know I shouldn't be using ISO-8859-1... but right now I have a bunch
> of
> >>> those properties files. Is there an easy way to get around this?....
> >>> After
> >>> looking into changes I see the line (379)....
> >>>
> >>> Reader reader = new InputStreamReader(is, "UTF-8");
> >>>
> >>> Shouldn't this be cofingurable somehow?
> >>>
> >>> Best,
> >>>
> >>> Ernesto
> >>>
> >>>
> >>> On Mon, Sep 28, 2009 at 2:33 AM, Igor Vaynberg <
> igor.vaynberg@gmail.com
> >>>>
> >>>> wrote:
> >>>
> >>>> all votes are more then welcome.
> >>>>
> >>>> -igor
> >>>>
> >>>> On Sun, Sep 27, 2009 at 5:20 PM, Sam Stainsby
> >>>> <sa...@sustainablesoftware.com.au> wrote:
> >>>>>
> >>>>> Are non-binding votes preferred or discouraged here? If the former,
> >>>
> >>> then
> >>>>>
> >>>>> after some testing with my projects:
> >>>>>
> >>>>> (nonbinding)
> >>>>> [X] Yes release
> >>>>> [ ] No, don't release it and here is why...
> >>>>>
> >>>>>
> >>>>
> >>>
> >
> >
>