You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/01/30 02:38:44 UTC
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19452
Change subject: IMPALA-11285: Deflake timeout in test_async_load
......................................................................
IMPALA-11285: Deflake timeout in test_async_load
The LOAD statement in TestAsyncLoadData.test_async_load intermittently
times out in S3 builds. The test doesn't measure the performance of the
query execution. It just makes sure the query succeed and asserts it
waits more than 3s (when enable_async_load_data = True). It doesn't make
sense to fail the test if the query runs longer than 10s.
This bumps the timeout from 10s to 20s.
Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c
---
M tests/metadata/test_load.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/19452/1
--
To view, visit http://gerrit.cloudera.org:8080/19452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c
Gerrit-Change-Number: 19452
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 )
Change subject: IMPALA-11285: Deflake timeout in test_async_load
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9003/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c
Gerrit-Change-Number: 19452
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 01:28:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 )
Change subject: IMPALA-11285: Deflake timeout in test_async_load
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12254/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c
Gerrit-Change-Number: 19452
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 02:58:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 )
Change subject: IMPALA-11285: Deflake timeout in test_async_load
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c
Gerrit-Change-Number: 19452
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 06:33:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 )
Change subject: IMPALA-11285: Deflake timeout in test_async_load
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c
Gerrit-Change-Number: 19452
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 16:13:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 )
Change subject: IMPALA-11285: Deflake timeout in test_async_load
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c
Gerrit-Change-Number: 19452
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 01:28:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19452 )
Change subject: IMPALA-11285: Deflake timeout in test_async_load
......................................................................
IMPALA-11285: Deflake timeout in test_async_load
The LOAD statement in TestAsyncLoadData.test_async_load intermittently
times out in S3 builds. The test doesn't measure the performance of the
query execution. It just makes sure the query succeed and asserts it
waits more than 3s (when enable_async_load_data = True). It doesn't make
sense to fail the test if the query runs longer than 10s.
This bumps the timeout from 10s to 20s.
Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c
Reviewed-on: http://gerrit.cloudera.org:8080/19452
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_load.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c
Gerrit-Change-Number: 19452
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-11285: Deflake timeout in test async load
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19452 )
Change subject: IMPALA-11285: Deflake timeout in test_async_load
......................................................................
Patch Set 1: Code-Review+2
Looks worth trying.
--
To view, visit http://gerrit.cloudera.org:8080/19452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1060aeb12bc4e90d676f79283ce378847dd16a3c
Gerrit-Change-Number: 19452
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 01:20:44 +0000
Gerrit-HasComments: No