You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2012/05/08 09:11:58 UTC

[Bug 53205] New: [PATCH] Fix some parsing errors and encoding issues

https://issues.apache.org/bugzilla/show_bug.cgi?id=53205

          Priority: P2
            Bug ID: 53205
          Assignee: dev@poi.apache.org
           Summary: [PATCH] Fix some parsing errors and encoding issues
          Severity: normal
    Classification: Unclassified
          Reporter: luke@nuix.com
          Hardware: PC
            Status: NEW
           Version: 3.9-dev
         Component: HDGF
           Product: POI

Created attachment 28741
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28741&action=edit
The patch to fix encoding problems.

A small patch to fix some encoding problems with older Visio documents and
handle errors more robustly.

I've signed an ICLA for a Derby patch previously.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53205] [PATCH] Fix some parsing errors and encoding issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53205

Yegor Kozlov <ye...@dinom.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Yegor Kozlov <ye...@dinom.ru> ---
Patch applied in r1365638

Thanks,
Yegor

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 53205] [PATCH] Fix some parsing errors and encoding issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53205

Yegor Kozlov <ye...@dinom.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Yegor Kozlov <ye...@dinom.ru> ---
Finally I had time to review your patch, thanks for your patience.

The patch looks good, but needs some work.

 POI is compatible with JDK 1.5 but your patch isn't. The Chunk class
constructs strings with String(byte[],int,int,java.nio.charset.Charset) which
wasd introduced in JDK 1.6. The old code used
StringUtil.getFromUnicodeLE(contents, startsAt, strLen) which assumed that
encoding is always UTF-16LE. I see that in your patch the encoding is either
ASCII or UTF-16LE depending on the chunk type. Can you write some unit tests
that show it is really so? 

Regards,
Yegor

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 53205] [PATCH] Fix some parsing errors and encoding issues

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53205

--- Comment #2 from Luke Quinane <lu...@nuix.com> ---
Created attachment 29111
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29111&action=edit
Patch to fix 1.5 support and add tests.

I think my changes in the latest patch should fix the JDK 1.5 support. I've
also added two unit tests and a sample file.

Cheers,

Luke

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org