[GitHub] [arrow] westonpace commented on a change in pull request #9465: ARROW-11391: [C++] Allow writing more than 2 GB to HDFS

[GitBox <gi...@apache.org>]

westonpace commented on a change in pull request #9465:
URL: https://github.com/apache/arrow/pull/9465#discussion_r573965510



##########
File path: cpp/src/arrow/io/hdfs.cc
##########
@@ -274,12 +288,20 @@ class HdfsOutputStream::HdfsOutputStreamImpl : public HdfsAnyFileImpl {
     return Status::OK();
   }
 
-  Status Write(const void* buffer, int64_t nbytes, int64_t* bytes_written) {
+  Status Write(const uint8_t* buffer, int64_t nbytes, int64_t* bytes_written) {

Review comment:
       Minor nitpick but why bother with `bytes_written` anymore?  It's discarded when going through the standard FS interfaces and with this change I don't see how it could ever be different from `nbytes` (else you'd never escape the while loop).
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org