You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/06/19 12:21:54 UTC

[GitHub] brooklyn-server pull request #738: Delete deprecated ApplicationBuilder

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/738

    Delete deprecated ApplicationBuilder

    Required updating lots of tests, often to extend `BrooklynAppLiveTestSupport` or `BrooklynAppUnitTestSupport`.
    
    Please first review/merge (to avoid those other repos failing when we delete `ApplicationBuilder`):
    * https://github.com/apache/brooklyn-library/pull/118
    * https://github.com/apache/brooklyn-dist/pull/96

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server delete-ApplicationBuilder

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #738
    
----
commit 96aaaf80bae4ba8a28438b55161f3c82a3e67818
Author: Aled Sage <al...@gmail.com>
Date:   2017-05-15T19:46:01Z

    Delete deprecated ApplicationBuilder
    
    Required updating lots of tests, often to extend
    BrooklynAppLiveTestSupport or BrooklynAppUnitTestSupport.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #738: Delete deprecated ApplicationBuilder

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/738
  
    @ahgittin changing a bunch of tests to extend `BrooklynAppUnitTestSupport` might well have sped things up (before the change, some of their `setUp` method created a normal `LocalManagementContext` rather than the minimalist `LocalManagementContextForTests.newInstance()`; the former would include the embedded Felix etc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #738: Delete deprecated ApplicationBuilder

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/738
  
    Something seems to have sped up tests significantly (1 to 2 mins) in the past week or two.  I'm blaming this PR!  In any case -- I'm happy (though slightly curious @aledsage if we can't explain the speedup there is a chance it's a sign we've disabled things we want!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #738: Delete deprecated ApplicationBuilder

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/738
  
    big job, very nice to have.  gotta love this:
    
    > +299 −1,329
    
    looks good and downstream changes are merged, so merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #738: Delete deprecated ApplicationBuilder

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/738


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---