You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/02/21 18:28:00 UTC
[jira] [Work logged] (GOBBLIN-1919) Simplify impl related to MR job execution (before reusing code in Temporal-based exec)
[ https://issues.apache.org/jira/browse/GOBBLIN-1919?focusedWorklogId=906299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906299 ]
ASF GitHub Bot logged work on GOBBLIN-1919:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/24 18:27
Start Date: 21/Feb/24 18:27
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3879:
URL: https://github.com/apache/gobblin/pull/3879#issuecomment-1957636227
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3879?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `8 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`492fea2`)](https://app.codecov.io/gh/apache/gobblin/commit/492fea22f68536f4ad9fdf6f14cefbade6b1b189?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 46.74% compared to head [(`89145e8`)](https://app.codecov.io/gh/apache/gobblin/pull/3879?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 41.83%.
| [Files](https://app.codecov.io/gh/apache/gobblin/pull/3879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/gobblin/util/JobLauncherUtils.java](https://app.codecov.io/gh/apache/gobblin/pull/3879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSm9iTGF1bmNoZXJVdGlscy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/gobblin/pull/3879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/gobblin/util/ParallelRunner.java](https://app.codecov.io/gh/apache/gobblin/pull/3879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvUGFyYWxsZWxSdW5uZXIuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/gobblin/pull/3879?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3879 +/- ##
============================================
- Coverage 46.74% 41.83% -4.92%
+ Complexity 11152 2198 -8954
============================================
Files 2216 469 -1747
Lines 87503 19910 -67593
Branches 9617 2321 -7296
============================================
- Hits 40904 8329 -32575
+ Misses 42908 10699 -32209
+ Partials 3691 882 -2809
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3879?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 906299)
Time Spent: 1.5h (was: 1h 20m)
> Simplify impl related to MR job execution (before reusing code in Temporal-based exec)
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1919
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1919
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Trivial
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)