You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2016/05/23 21:04:41 UTC

[GitHub] incubator-guacamole-server pull request: GUACAMOLE-35: Ensure perf...

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-server/pull/10

    GUACAMOLE-35: Ensure performance flag values are applied.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-server fix-perf-flags

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-server/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit 88b422987e9178e727bf7cba075230947643761b
Author: Michael Jumper <mj...@apache.org>
Date:   2016-04-19T00:25:10Z

    GUACAMOLE-35: Ensure performance flag values are applied.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request: GUACAMOLE-35: Ensure perf...

Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-server/pull/10#discussion_r64323904
  
    --- Diff: src/protocols/rdp/rdp_settings.c ---
    @@ -925,9 +925,31 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp* rdp) {
     
         /* Performance flags */
     #ifdef LEGACY_RDPSETTINGS
    +
    +    /* Explicitly set flag value */
         rdp_settings->performance_flags = guac_rdp_get_performance_flags(guac_settings);
    +
    +    /* Set individual flags - some FreeRDP versions overwrite the above */
    +    rdp_settings->smooth_fonts = guac_settings->font_smoothing_enabled;
    +    rdp_settings->disable_wallpaper = !guac_settings->wallpaper_enabled;
    +    rdp_settings->disable_full_window_drag = !guac_settings->full_window_drag_enabled;
    +    rdp_settings->disable_menu_animations = !guac_settings->menu_animations_enabled;
    +    rdp_settings->disable_theming = !guac_settings->theming_enabled;
    +    rdp_settings->desktop_composition = !guac_settings->desktop_composition_enabled;
    --- End diff --
    
    Should this be inverted here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request: GUACAMOLE-35: Ensure perf...

Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-server/pull/10#discussion_r64324511
  
    --- Diff: src/protocols/rdp/rdp_settings.c ---
    @@ -925,9 +925,31 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp* rdp) {
     
         /* Performance flags */
     #ifdef LEGACY_RDPSETTINGS
    +
    +    /* Explicitly set flag value */
         rdp_settings->performance_flags = guac_rdp_get_performance_flags(guac_settings);
    +
    +    /* Set individual flags - some FreeRDP versions overwrite the above */
    +    rdp_settings->smooth_fonts = guac_settings->font_smoothing_enabled;
    +    rdp_settings->disable_wallpaper = !guac_settings->wallpaper_enabled;
    +    rdp_settings->disable_full_window_drag = !guac_settings->full_window_drag_enabled;
    +    rdp_settings->disable_menu_animations = !guac_settings->menu_animations_enabled;
    +    rdp_settings->disable_theming = !guac_settings->theming_enabled;
    +    rdp_settings->desktop_composition = !guac_settings->desktop_composition_enabled;
    --- End diff --
    
    Yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request: GUACAMOLE-35: Ensure perf...

Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-server/pull/10#discussion_r64324278
  
    --- Diff: src/protocols/rdp/rdp_settings.c ---
    @@ -925,9 +925,31 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp* rdp) {
     
         /* Performance flags */
     #ifdef LEGACY_RDPSETTINGS
    +
    +    /* Explicitly set flag value */
         rdp_settings->performance_flags = guac_rdp_get_performance_flags(guac_settings);
    +
    +    /* Set individual flags - some FreeRDP versions overwrite the above */
    +    rdp_settings->smooth_fonts = guac_settings->font_smoothing_enabled;
    +    rdp_settings->disable_wallpaper = !guac_settings->wallpaper_enabled;
    +    rdp_settings->disable_full_window_drag = !guac_settings->full_window_drag_enabled;
    +    rdp_settings->disable_menu_animations = !guac_settings->menu_animations_enabled;
    +    rdp_settings->disable_theming = !guac_settings->theming_enabled;
    +    rdp_settings->desktop_composition = !guac_settings->desktop_composition_enabled;
    --- End diff --
    
    Yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request: GUACAMOLE-35: Ensure perf...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-server/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request: GUACAMOLE-35: Ensure perf...

Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-server/pull/10#discussion_r64324484
  
    --- Diff: src/protocols/rdp/rdp_settings.c ---
    @@ -925,9 +925,31 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp* rdp) {
     
         /* Performance flags */
     #ifdef LEGACY_RDPSETTINGS
    +
    +    /* Explicitly set flag value */
         rdp_settings->performance_flags = guac_rdp_get_performance_flags(guac_settings);
    +
    +    /* Set individual flags - some FreeRDP versions overwrite the above */
    +    rdp_settings->smooth_fonts = guac_settings->font_smoothing_enabled;
    +    rdp_settings->disable_wallpaper = !guac_settings->wallpaper_enabled;
    +    rdp_settings->disable_full_window_drag = !guac_settings->full_window_drag_enabled;
    +    rdp_settings->disable_menu_animations = !guac_settings->menu_animations_enabled;
    +    rdp_settings->disable_theming = !guac_settings->theming_enabled;
    +    rdp_settings->desktop_composition = !guac_settings->desktop_composition_enabled;
    --- End diff --
    
    Meaning that you should remove the ! that inverts the setting here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---