You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2011/09/13 03:12:53 UTC

svn_error_t *make_foo(svn_foo_t **foo_p, apr_pool_t *result, apr_pool_t *scratch);

[RFC] In new code, rename RESULT_POOL and SCRATCH_POOL to RESULT and
SCRATCH, respectively.

Because the names are too long and C is strongly typed.


-- 
(This has been on my mind since some time, I probably mentioned it in
passing a few times already, I don't think I've RFC'd it yet.)

Re: svn_error_t *make_foo(svn_foo_t **foo_p, apr_pool_t *result, apr_pool_t *scratch);

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Stefan Sperling wrote on Tue, Sep 13, 2011 at 19:31:30 +0200:
> On Tue, Sep 13, 2011 at 09:39:11AM -0500, Hyrum K Wright wrote:
> > On Tue, Sep 13, 2011 at 9:02 AM, C. Michael Pilato <cm...@collab.net> wrote:
> > > On 09/12/2011 09:12 PM, Daniel Shahaf wrote:
> > >> [RFC] In new code, rename RESULT_POOL and SCRATCH_POOL to RESULT and
> > >> SCRATCH, respectively.
> > >>
> > >> Because the names are too long and C is strongly typed.
> > >
> > > Meh.
> > >
> > > Or, to be more formal about it: -0.
> > 
> > Maybe I'm just getting crotchety in my old age, but I'm also -0 on
> > this proposal.
> 
> Me too. Let's keep the names as they are.
> 

Okay.

> Changing this convention would also introduce naming inconsistencies
> we'd have to fix up at some point, for no real gain whatsoever.

If inconsistencies had been the issue I would have offered to rename the
variables throughout the tree.

Re: svn_error_t *make_foo(svn_foo_t **foo_p, apr_pool_t *result, apr_pool_t *scratch);

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Sep 13, 2011 at 09:39:11AM -0500, Hyrum K Wright wrote:
> On Tue, Sep 13, 2011 at 9:02 AM, C. Michael Pilato <cm...@collab.net> wrote:
> > On 09/12/2011 09:12 PM, Daniel Shahaf wrote:
> >> [RFC] In new code, rename RESULT_POOL and SCRATCH_POOL to RESULT and
> >> SCRATCH, respectively.
> >>
> >> Because the names are too long and C is strongly typed.
> >
> > Meh.
> >
> > Or, to be more formal about it: -0.
> 
> Maybe I'm just getting crotchety in my old age, but I'm also -0 on
> this proposal.

Me too. Let's keep the names as they are.

Changing this convention would also introduce naming inconsistencies
we'd have to fix up at some point, for no real gain whatsoever.

Re: svn_error_t *make_foo(svn_foo_t **foo_p, apr_pool_t *result, apr_pool_t *scratch);

Posted by Hyrum K Wright <hy...@wandisco.com>.
On Tue, Sep 13, 2011 at 9:02 AM, C. Michael Pilato <cm...@collab.net> wrote:
> On 09/12/2011 09:12 PM, Daniel Shahaf wrote:
>> [RFC] In new code, rename RESULT_POOL and SCRATCH_POOL to RESULT and
>> SCRATCH, respectively.
>>
>> Because the names are too long and C is strongly typed.
>
> Meh.
>
> Or, to be more formal about it: -0.

Maybe I'm just getting crotchety in my old age, but I'm also -0 on
this proposal.

-Hyrum



-- 

uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/

Re: svn_error_t *make_foo(svn_foo_t **foo_p, apr_pool_t *result, apr_pool_t *scratch);

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Bert Huijben wrote on Tue, Sep 13, 2011 at 16:07:33 +0200:
> I think it hurts readability of patches.

I assumed we'd get used to those names, much like all variables called
'props' are hashes mapping const char * keys to svn_string_t * values,
all variables called 'ffd' are of type fs_fs_data_t *, all variables
called 'status' are apr_status_t...

RE: svn_error_t *make_foo(svn_foo_t **foo_p, apr_pool_t *result, apr_pool_t *scratch);

Posted by Bert Huijben <be...@qqmail.nl>.

> -----Original Message-----
> From: C. Michael Pilato [mailto:cmpilato@collab.net]
> Sent: dinsdag 13 september 2011 16:02
> To: Daniel Shahaf
> Cc: dev@subversion.apache.org
> Subject: Re: svn_error_t *make_foo(svn_foo_t **foo_p, apr_pool_t
> *result, apr_pool_t *scratch);
> 
> On 09/12/2011 09:12 PM, Daniel Shahaf wrote:
> > [RFC] In new code, rename RESULT_POOL and SCRATCH_POOL to RESULT
> and
> > SCRATCH, respectively.
> >
> > Because the names are too long and C is strongly typed.
> 
> Meh.
> 
> Or, to be more formal about it: -0.

-0 too.

I think it hurts readability of patches.

	Bert

Re: svn_error_t *make_foo(svn_foo_t **foo_p, apr_pool_t *result, apr_pool_t *scratch);

Posted by "C. Michael Pilato" <cm...@collab.net>.
On 09/12/2011 09:12 PM, Daniel Shahaf wrote:
> [RFC] In new code, rename RESULT_POOL and SCRATCH_POOL to RESULT and
> SCRATCH, respectively.
> 
> Because the names are too long and C is strongly typed.

Meh.

Or, to be more formal about it: -0.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand