You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2014/05/19 22:09:04 UTC
svn commit: r1596036 -
/lucene/dev/branches/lucene_solr_4_8/dev-tools/scripts/smokeTestRelease.py
Author: mikemccand
Date: Mon May 19 20:09:04 2014
New Revision: 1596036
URL: http://svn.apache.org/r1596036
Log:
LUCENE-5686: fail if LUCENE/SOLR_NNNN (_ instead of -) appears in changes
Modified:
lucene/dev/branches/lucene_solr_4_8/dev-tools/scripts/smokeTestRelease.py
Modified: lucene/dev/branches/lucene_solr_4_8/dev-tools/scripts/smokeTestRelease.py
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_8/dev-tools/scripts/smokeTestRelease.py?rev=1596036&r1=1596035&r2=1596036&view=diff
==============================================================================
--- lucene/dev/branches/lucene_solr_4_8/dev-tools/scripts/smokeTestRelease.py (original)
+++ lucene/dev/branches/lucene_solr_4_8/dev-tools/scripts/smokeTestRelease.py Mon May 19 20:09:04 2014
@@ -468,12 +468,22 @@ def testChangesText(dir, version, projec
checkChangesContent(open(fullPath, encoding='UTF-8').read(), version, fullPath, project, False)
reChangesSectionHREF = re.compile('<a id="(.*?)".*?>(.*?)</a>', re.IGNORECASE)
-
+reUnderbarNotDashHTML = re.compile(r'<li>(\s*(LUCENE|SOLR)_\d\d\d\d+)')
+reUnderbarNotDashTXT = re.compile(r'\s+((LUCENE|SOLR)_\d\d\d\d+)', re.MULTILINE)
def checkChangesContent(s, version, name, project, isHTML):
if isHTML and s.find('Release %s' % version) == -1:
raise RuntimeError('did not see "Release %s" in %s' % (version, name))
+ if isHTML:
+ r = reUnderbarNotDashHTML
+ else:
+ r = reUnderbarNotDashTXT
+
+ m = r.search(s)
+ if m is not None:
+ raise RuntimeError('incorrect issue (_ instead of -) in %s: %s' % (name, m.group(1)))
+
if s.lower().find('not yet released') != -1:
raise RuntimeError('saw "not yet released" in %s' % name)