You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "josh-fell (via GitHub)" <gi...@apache.org> on 2023/02/21 20:37:24 UTC
[GitHub] [airflow] josh-fell opened a new pull request, #29678: FIx formatting of Dataset inlet/outlet note in TaskFlow concepts
josh-fell opened a new pull request, #29678:
URL: https://github.com/apache/airflow/pull/29678
**Before**
<img width="932" alt="image" src="https://user-images.githubusercontent.com/48934154/220452755-2f674ada-b405-4bc7-ab12-77215c8bcfd7.png">
**After**
<img width="936" alt="image" src="https://user-images.githubusercontent.com/48934154/220452840-69c8d89c-406b-4781-8006-7cc12818b485.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vemikhaylov commented on pull request #29678: FIx formatting of Dataset inlet/outlet note in TaskFlow concepts
Posted by "vemikhaylov (via GitHub)" <gi...@apache.org>.
vemikhaylov commented on PR #29678:
URL: https://github.com/apache/airflow/pull/29678#issuecomment-1440862879
> it looked like the rST had a directive started but never finished (i.e. just a hanging `..`);
I'm definitely not an RST expert, but I think just a single "::" quotes the paragraph below exactly as it was seen on your screenshot in the PR description. On wiki they call it "blockquoting" (https://en.wikipedia.org/wiki/ReStructuredText).
> however, if you feel there are improvements to be made to the docs, PRs are absolutely welcome! If that includes converting these explicit notes to a formatted one, I'd say go for it.
Sure thing, I'll create a PR to move to the explicit RST note usage where possible. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #29678: FIx formatting of Dataset inlet/outlet note in TaskFlow concepts
Posted by "josh-fell (via GitHub)" <gi...@apache.org>.
josh-fell commented on PR #29678:
URL: https://github.com/apache/airflow/pull/29678#issuecomment-1439340653
> Can it make sense to replace all (or almost all) such "Note: " places in ".rst" with the corresponding formatting?
>
> For instance,
>
> https://airflow.apache.org/docs/apache-airflow-providers-google/stable/operators/cloud/video_intelligence.html
>
> https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-google/operators/cloud/video_intelligence.rst#more-information
>
> <img alt="Screenshot 2023-02-21 at 21 38 26" width="736" src="https://user-images.githubusercontent.com/38596482/220464962-e732ebb9-5b38-42e5-82c2-dec8161b637e.png">
@vemikhaylov Maybe? This was fixing readability and it looked like the rST had a directive started but never finished (i.e. just a hanging `..`); however, if you feel there are improvements to be made to the docs, PRs are absolutely welcome! If that includes converting these explicit notes to a formatted one, I'd say go for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis merged pull request #29678: FIx formatting of Dataset inlet/outlet note in TaskFlow concepts
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis merged PR #29678:
URL: https://github.com/apache/airflow/pull/29678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vemikhaylov commented on pull request #29678: FIx formatting of Dataset inlet/outlet note in TaskFlow concepts
Posted by "vemikhaylov (via GitHub)" <gi...@apache.org>.
vemikhaylov commented on PR #29678:
URL: https://github.com/apache/airflow/pull/29678#issuecomment-1439128327
Can it make sense to replace all (or almost all) such "Note: " places in ".rst" with the corresponding formatting?
For instance,
https://airflow.apache.org/docs/apache-airflow-providers-google/stable/operators/cloud/video_intelligence.html
https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-google/operators/cloud/video_intelligence.rst#more-information
<img width="736" alt="Screenshot 2023-02-21 at 21 38 26" src="https://user-images.githubusercontent.com/38596482/220464962-e732ebb9-5b38-42e5-82c2-dec8161b637e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org