You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/04/03 17:28:07 UTC
Review Request 32812: RU: Block users from installing a Version with
the same existing Version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32812/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-10349
https://issues.apache.org/jira/browse/AMBARI-10349
Repository: ambari
Description
-------
When creating a Version, if a user accidentally, or unknowingly uses the same repo, or a repo that has RPM's with the same version as the current Version, it can be installed successfully. The result is that rolling upgrades will fail as the versions show up the same in hdp-select because the packages are the same.
Validate either on Version "registration" or on attempted Version "install" that the software in the repository match an already existing registered version.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java dbad19a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 4efdb0c
Diff: https://reviews.apache.org/r/32812/diff/
Testing
-------
in progress
Thanks,
Dmitro Lisnichenko
Re: Review Request 32812: RU: Block users from installing a Version
with the same existing Version
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32812/#review78843
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/32812/#comment127914>
I suggest making HDP-UTILS a constant.
- Alejandro Fernandez
On April 3, 2015, 4:06 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32812/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 4:06 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-10349
> https://issues.apache.org/jira/browse/AMBARI-10349
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When creating a Version, if a user accidentally, or unknowingly uses the same repo, or a repo that has RPM's with the same version as the current Version, it can be installed successfully. The result is that rolling upgrades will fail as the versions show up the same in hdp-select because the packages are the same.
> Validate either on Version "registration" or on attempted Version "install" that the software in the repository match an already existing registered version.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java dbad19a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 4efdb0c
>
> Diff: https://reviews.apache.org/r/32812/diff/
>
>
> Testing
> -------
>
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.358s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [2.067s]
> [INFO] Ambari Server ..................................... SUCCESS [34:23.217s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:29.262s
> [INFO] Finished at: Fri Apr 03 18:58:23 EEST 2015
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 32812: RU: Block users from installing a Version
with the same existing Version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32812/
-----------------------------------------------------------
(Updated April 3, 2015, 4:06 p.m.)
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-10349
https://issues.apache.org/jira/browse/AMBARI-10349
Repository: ambari
Description
-------
When creating a Version, if a user accidentally, or unknowingly uses the same repo, or a repo that has RPM's with the same version as the current Version, it can be installed successfully. The result is that rolling upgrades will fail as the versions show up the same in hdp-select because the packages are the same.
Validate either on Version "registration" or on attempted Version "install" that the software in the repository match an already existing registered version.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java dbad19a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 4efdb0c
Diff: https://reviews.apache.org/r/32812/diff/
Testing (updated)
-------
OK
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.358s]
[INFO] Ambari Metrics Common ............................. SUCCESS [2.067s]
[INFO] Ambari Server ..................................... SUCCESS [34:23.217s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:29.262s
[INFO] Finished at: Fri Apr 03 18:58:23 EEST 2015
Thanks,
Dmitro Lisnichenko
Re: Review Request 32812: RU: Block users from installing a Version
with the same existing Version
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32812/#review78779
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Квітень 3, 2015, 3:28 після полудня, Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32812/
> -----------------------------------------------------------
>
> (Updated Квітень 3, 2015, 3:28 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-10349
> https://issues.apache.org/jira/browse/AMBARI-10349
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When creating a Version, if a user accidentally, or unknowingly uses the same repo, or a repo that has RPM's with the same version as the current Version, it can be installed successfully. The result is that rolling upgrades will fail as the versions show up the same in hdp-select because the packages are the same.
> Validate either on Version "registration" or on attempted Version "install" that the software in the repository match an already existing registered version.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java dbad19a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 4efdb0c
>
> Diff: https://reviews.apache.org/r/32812/diff/
>
>
> Testing
> -------
>
> in progress
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>