You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Ole Solberg (JIRA)" <ji...@apache.org> on 2007/10/30 15:47:50 UTC
[jira] Created: (DERBY-3163) Derby JUnit test framework adpations
to run existing tests against replicated databases
Derby JUnit test framework adpations to run existing tests against replicated databases
---------------------------------------------------------------------------------------
Key: DERBY-3163
URL: https://issues.apache.org/jira/browse/DERBY-3163
Project: Derby
Issue Type: Sub-task
Components: Test
Affects Versions: 10.4.0.0
Reporter: Ole Solberg
Assignee: Ole Solberg
Priority: Minor
Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
and junit tests)
This requires
- Running existing tests against already started servers on "non-localhost" machines.
- verificationclients checking slave vs. master.
- ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541778 ]
Ole Solberg commented on DERBY-3163:
------------------------------------
Thank you for looking into this Kristian!
The patch is not ready for commit as you suspected.
I think the best approach would be to get derby-2807-v1.diff.txt (in DERBY-2807) committed first, which would give a smaller and cleaner patch for DERBY-3163.
The System.out.printlns are not supposed to be there, they are leftovers from my initial testing against the replication "Proof of concept" code.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.2-v1.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3163:
-------------------------------
Attachment: derby-3163.1-v4.diff.txt
derby-3163.2-v4.diff.txt
>
> Is there a write up that explains what the changes are? Several of the new methods in TestConfiguration have no comments so I have no idea what their purpose is.
derby-3163.1-v4.diff.txt
------------------------
- TestConfiguration:
Add decorators which takes server host and port, for running tests in a
server/client configuration, where a server has already
been started on a that host and port.
- CleanDatabaseTestSetup:
Added a constructor which takes server host and port, for an already started server in a
client/server configuration, to run the SQL decoration on that server.
Comments are now included for the added test decorators (plus for a couple of existing decorators
which also lacked comments.)
>
> The switch to a static decorate() method in some of the tests is confusing. Is there some explanation for why this is required, is this a pattern required for all tests?
>
derby-3163.2-v4.diff.txt
------------------------
- AnsiTrimTest, CreateTableFromQueryTest:
Factored out the SQL statement execution for database content setup to
be able to reuse the same code in other TestCases which add the same
test method in their 'suite()' method.
Currently this is done for a few testcases reused in replication testing:
o.a.dT.ft.tests.replicationTests.StandardTests: e.g. as 'AnsiTrimTest.decorate(s);' (derby-3164.1)
This pattern is required for all tests which is to be used in other
TestCases which add the same test method in their 'suite()' method.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.1-v3.diff.txt, derby-3163.1-v4.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt, derby-3163.2-v3.diff.txt, derby-3163.2-v4.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541766 ]
Kristian Waagan commented on DERBY-3163:
----------------------------------------
I had a look at 'derby-3163.1-v1.diff.txt', and saw that there are quite some lines commented out and comments indicating more changes have to be done before the test framework is ready for the task. Also, are the System.out.printlns supposed to be in there?
Is the patch intended for commit?
Can you say something about what has to be done to push this issue to completion?
thanks,
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.2-v1.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3163:
-------------------------------
Summary: Derby JUnit test framework adaptions to run existing tests against replicated databases (was: Derby JUnit test framework adpations to run existing tests against replicated databases)
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567687#action_12567687 ]
Øystein Grøvlen commented on DERBY-3163:
----------------------------------------
Thanks for the patch, Ole.
1. TestConfiguration: I see several questions and remarks like "This
looks bogus" in comments that makes me a bit unsure about how ready
this patch is. I think some of the comments should be cleaned up.
2. CleanDatabaseTestSetup:
a. The added constructor is as far as I can see, not used. Is
future use planned? It is not clear to me when you would use
this as opposed to the new methods in TestConfiguration.
b. Why are the added fields static?
c. setUp() contains two assignments to current. The first does not
seem to serve any purpose since, if the variable is used, it
will always be set a second time before it is used.
3. AnsiTrimTest/CreateTableFromQueryTest: It is not clear to me what
the purpose of the refactoring of the statement executions is. Is
this just preparing for future changes?
4. Minor nits:
a. Several lines are longer that 80 chars.
b. Code that is commented out.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3163:
-------------------------------
Attachment: derby-3163.1-v1.diff.txt
First version of Derby JUnit test framework adaptions to run existing tests against replicated databases.
Actually mods. to be able to run tests against *already started servers*.
java/testing/org/apache/derbyTesting/junit/TestConfiguration.java:
------------------------------------------------------------------
NB. also includes the modifications to TestConfiguration.java
submitted in derby-2807-v1.diff.txt.
derby-2807-v1.diff.txt is not yet committed.
+ getDEFAULT_CONFIG()
+ existingServerSuite(Class testClass,
boolean cleanDB,
String hostName,
int portNumber)
+ existingServerDecorator(Test test, String hostName, int PortNumber)
java/testing/org/apache/derbyTesting/junit/CleanDatabaseTestSetup.java:
-----------------------------------------------------------------------
+ CleanDatabaseTestSetup(Test test,
boolean useNetworkClient,
String hostName,
int portNo)
+ jdbcClient
+ hostName
+ portNo
M setUp() - set jdbcClient, hostName, portNo in current TestConfiguration.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Øystein Grøvlen updated DERBY-3163:
-----------------------------------
Derby Info: (was: [Patch Available])
Thanks, Ole. Committed v4 of patches as revision 628073.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.1-v3.diff.txt, derby-3163.1-v4.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt, derby-3163.2-v3.diff.txt, derby-3163.2-v4.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568274#action_12568274 ]
Daniel John Debrunner commented on DERBY-3163:
----------------------------------------------
Is there a write up that explains what the changes are? Several of the new methods in TestConfiguration have no comments so I have no idea what their purpose is.
The switch to a static decorate() method in some of the tests is confusing. Is there some explanation for why this is required, is this a pattern required for all tests?
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.1-v3.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt, derby-3163.2-v3.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3163:
-------------------------------
Attachment: derby-3163.2-v2.diff.txt
derby-3163.1-v2.diff.txt
New version of the derby-3163.1 and derby-3163.2 patches.
These patches are needed for the replication test framework and replication tests:
I plan to submit new patches for 3162 - replication test framework, and 3164 - replication tests in a couple of days.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3163:
-------------------------------
Attachment: derby-3163.2-v1.diff.txt
Example modifications to existing tests to exploit test decorators in cases when running tests
against already running servers.
java/testing/org/apache/derbyTesting/functionTests/tests/lang/AnsiTrimTest.java:
java/testing/org/apache/derbyTesting/functionTests/tests/lang/CreateTableFromQueryTest.java:
Separate out 'public static void decorate(Statement s)' to be used in 'decorateSQL(Statement s)'
also in the replication tests where decorators are run against already running servers.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.2-v1.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Øystein Grøvlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568925#action_12568925 ]
Øystein Grøvlen commented on DERBY-3163:
----------------------------------------
I think the latest versions of the patches look. The added comments are very useful. My only remark is that it would be good if you could have used javadoc tags (e.g., @param and @returns) where applicable.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.1-v3.diff.txt, derby-3163.1-v4.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt, derby-3163.2-v3.diff.txt, derby-3163.2-v4.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3163) Derby JUnit test framework adaptions to
run existing tests against replicated databases
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg closed DERBY-3163.
------------------------------
Resolution: Fixed
Currently planned framework and tests for trunk and 10.4 branch are committed and used in nightly tests: Closing.
Additional improvements and additions will be traced by new JIRA issues.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.1-v3.diff.txt, derby-3163.1-v4.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt, derby-3163.2-v3.diff.txt, derby-3163.2-v4.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3163:
-------------------------------
Derby Info: [Patch Available]
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Solberg updated DERBY-3163:
-------------------------------
Attachment: derby-3163.1-v3.diff.txt
derby-3163.2-v3.diff.txt
Thanks for looking at this patch, Øystein!
> Øystein Grøvlen commented on DERBY-3163:
> ----------------------------------------
.
> 1. TestConfiguration: I see several questions and remarks like "This
> looks bogus" in comments that makes me a bit unsure about how ready
> this patch is. I think some of the comments should be cleaned up.
This was partly comments copy/pasted from "original" methods used as base
for the variants needed when specifying host and port in a client/server
context.
Cleaned up now.
>
> 2. CleanDatabaseTestSetup:
> a. The added constructor is as far as I can see, not used. Is
> future use planned? It is not clear to me when you would use
> this as opposed to the new methods in TestConfiguration.
It is for future use as in derby-3164.1-v1.diff.txt.
>
> b. Why are the added fields static?
Removed static.
>
> c. setUp() contains two assignments to current. The first does not
> seem to serve any purpose since, if the variable is used, it
> will always be set a second time before it is used.
Fixed.
>
> 3. AnsiTrimTest/CreateTableFromQueryTest: It is not clear to me what
> the purpose of the refactoring of the statement executions is. Is
> this just preparing for future changes?
Yes, it is preparing for 3164.
This is to be able to run existing JUnit tests in a replication context
(specifying host and port in a client/server context).
derby-3164.1-v1.diff.txt defines a suite including a subset of the existing
JUnit tests for running in client/server context.
Tests which use decorateSQL() must use networkclient when running setUp/decorateSQL
in this context.
>
> 4. Minor nits:
> a. Several lines are longer that 80 chars.
Fixed.
>
> b. Code that is commented out.
Fixed.
>
I will report back when tests are finished.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.1-v3.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt, derby-3163.2-v3.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3163) Derby JUnit test framework adaptions
to run existing tests against replicated databases
Posted by "Ole Solberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568232#action_12568232 ]
Ole Solberg commented on DERBY-3163:
------------------------------------
derbyall and suites.All: OK.
Local/uncommitted replication tests: OK wrt. the current state of replication.
> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>
> Key: DERBY-3163
> URL: https://issues.apache.org/jira/browse/DERBY-3163
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Ole Solberg
> Assignee: Ole Solberg
> Priority: Minor
> Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.1-v3.diff.txt, derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt, derby-3163.2-v3.diff.txt
>
>
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
> and junit tests)
> This requires
> - Running existing tests against already started servers on "non-localhost" machines.
> - verificationclients checking slave vs. master.
> - ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.