[GitHub] [airflow] uranusjr commented on a diff in pull request #32589: BUGFIX: AWS ECS trigger returned "success" after max_attempts instead of failing

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #32589:
URL: https://github.com/apache/airflow/pull/32589#discussion_r1263374934


##########
airflow/providers/amazon/aws/triggers/ecs.py:
##########
@@ -179,8 +181,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
                 finally:
                     if self.log_group and self.log_stream:
                         logs_token = await self._forward_logs(logs_client, logs_token)
-
-        yield TriggerEvent({"status": "success", "task_arn": self.task_arn})
+        raise AirflowException("Waiter error: max attempts reached")

Review Comment:
   This should yield a failure event instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org