You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "leerho (via GitHub)" <gi...@apache.org> on 2026/09/28 23:51:34 UTC
[PR] Add missing and includes to hll and cpc internal headers [datasketches-cpp]
leerho opened a new pull request, #530:
URL: https://github.com/apache/datasketches-cpp/pull/530
Fixes #499.
#500 fixed the reported GCC 15 failure in `fi/include/reverse_purge_hash_map.hpp` (plus `common/include/serde.hpp`) and added GCC 9–15 and C++11–23 jobs to CI. This PR covers the issue's remaining concern that other headers might have the same problem.
I compiled each header standalone against libc++ with `-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES`, which approximates GCC 15's stricter headers. Every public entry-point header passed. Two internal headers use fixed-width integer types without including `<cstdint>` and compile only because of include order, which is the same latent condition that broke `reverse_purge_hash_map.hpp`:
- `hll/include/coupon_iterator.hpp`: uses `uint32_t` and `std::input_iterator_tag`. `AuxHashMap.hpp` includes it right after `<iostream>`, `<memory>` and `<functional>`. Added `<cstdint>` and `<iterator>`.
- `cpc/include/compression_data.hpp`: uses `uint8_t` and `uint16_t`. Currently safe only because `common_defs.hpp` is included first. Added `<cstdint>`.
No behavior change. The full test suite passes locally (Apple clang, C++11).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Add missing and includes to hll and cpc internal headers [datasketches-cpp]
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #530:
URL: https://github.com/apache/datasketches-cpp/pull/530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Add missing and includes to hll and cpc internal headers [datasketches-cpp]
Posted by "coveralls (via GitHub)" <gi...@apache.org>.
coveralls commented on PR #530:
URL: https://github.com/apache/datasketches-cpp/pull/530#issuecomment-5880968809
## Coverage Report for [CI Build 36500174923](https://coveralls.io/builds/82023405)
### Coverage remained the same at **82.389%**
### Details
- Coverage remained the same as the [base build](https://coveralls.io/builds/81949935).
- **Patch coverage**: No coverable lines changed in this PR.
- No coverage regressions found.
### Uncovered Changes
No uncovered changes found.
### Coverage Regressions
No coverage regressions found.
---
### Coverage Stats
| | [](https://coveralls.io/builds/82023405) |
| :-- | --: |
| Relevant Lines: | 21560 |
| Covered Lines: | 17763 |
| Line Coverage: | 82.39% |
| Coverage Strength: | 1363989.29 hits per line |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org