You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by jw...@apache.org on 2016/01/24 19:00:02 UTC
groovy git commit: ManagedReference#finalizeReference stackoverflow
on call to removeStallEntries
Repository: groovy
Updated Branches:
refs/heads/GROOVY_2_4_X 7a9dcef3c -> bc68bbef2
ManagedReference#finalizeReference stackoverflow on call to removeStallEntries
The initial call to finalizeReference will normally originate from ReferenceManager#removeStallEntries. Having finalizeReference call removeStallEntries (via clear) can create a cycle resulting in a stackoverflow.
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/bc68bbef
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/bc68bbef
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/bc68bbef
Branch: refs/heads/GROOVY_2_4_X
Commit: bc68bbef2424b3247e440177a74119624691e416
Parents: 7a9dcef
Author: John Wagenleitner <jw...@apache.org>
Authored: Sun Jan 24 09:58:50 2016 -0800
Committer: John Wagenleitner <jw...@apache.org>
Committed: Sun Jan 24 09:58:50 2016 -0800
----------------------------------------------------------------------
src/main/org/codehaus/groovy/util/ManagedReference.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/bc68bbef/src/main/org/codehaus/groovy/util/ManagedReference.java
----------------------------------------------------------------------
diff --git a/src/main/org/codehaus/groovy/util/ManagedReference.java b/src/main/org/codehaus/groovy/util/ManagedReference.java
index 4c211c3..391f522 100644
--- a/src/main/org/codehaus/groovy/util/ManagedReference.java
+++ b/src/main/org/codehaus/groovy/util/ManagedReference.java
@@ -50,6 +50,6 @@ public class ManagedReference<T> implements Finalizable {
}
public void finalizeReference(){
- clear();
+ ref.clear();
}
}
\ No newline at end of file