You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2026/01/06 07:40:28 UTC
(arrow) branch main updated: GH-48725: [C++] Fix bundled Protobuf doesn't exist in libarrow_bundled_dependencies (#48726)
This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 4f1cac1948 GH-48725: [C++] Fix bundled Protobuf doesn't exist in libarrow_bundled_dependencies (#48726)
4f1cac1948 is described below
commit 4f1cac1948f191001e86b5a344cefea0cdb35b5f
Author: Sutou Kouhei <ko...@clear-code.com>
AuthorDate: Tue Jan 6 16:40:21 2026 +0900
GH-48725: [C++] Fix bundled Protobuf doesn't exist in libarrow_bundled_dependencies (#48726)
### Rationale for this change
We need to update `ARROW_BUNDLED_STATIC_LIBS` in the parent scope because GH-48183 changed to `function(build_protobuf)` from `macro(build_protobuf)`.
### What changes are included in this PR?
Update `ARROW_BUNDLED_STATIC_LIBS` in the parent scope.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
* GitHub Issue: #48725
Authored-by: Sutou Kouhei <ko...@clear-code.com>
Signed-off-by: Sutou Kouhei <ko...@clear-code.com>
---
cpp/cmake_modules/ThirdpartyToolchain.cmake | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 8a26b46d0b..42fa5e34b3 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1974,7 +1974,9 @@ function(build_protobuf)
# Make protobuf_fc depend on the install completion marker
add_custom_target(protobuf_fc DEPENDS "${PROTOBUF_PREFIX}/.protobuf_installed")
- list(APPEND ARROW_BUNDLED_STATIC_LIBS protobuf::libprotobuf)
+ set(ARROW_BUNDLED_STATIC_LIBS
+ ${ARROW_BUNDLED_STATIC_LIBS} protobuf::libprotobuf
+ PARENT_SCOPE)
if(CMAKE_CROSSCOMPILING)
# If we are cross compiling, we need to build protoc for the host