You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Harold Dost <h....@criteo.com> on 2018/05/06 15:03:35 UTC
Review Request 66975: Add documentation for the xfs_kill_containers
flag.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66975/
-----------------------------------------------------------
Review request for mesos, Greg Mann and James Peach.
Bugs: MESOS-6575
https://issues.apache.org/jira/browse/MESOS-6575
Repository: mesos
Description
-------
- Add to disk xfs isolator page
- Add to the upgrades page
Diffs
-----
docs/isolators/disk-xfs.md e56f6473d0bffc6574b9abdfc9843961c2d0b688
docs/upgrades.md 512d5d9067812cf73351f5be6bd244856a36e1dc
Diff: https://reviews.apache.org/r/66975/diff/1/
Testing
-------
Thanks,
Harold Dost
Re: Review Request 66975: Add documentation for the
xfs-kill-containers flag.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66975/#review202552
-----------------------------------------------------------
Fix it, then Ship it!
I'll make these edits as I commit.
docs/isolators/disk-xfs.md
Lines 43 (patched)
<https://reviews.apache.org/r/66975/#comment284368>
Should be `--xfs_kill_containers`.
docs/isolators/disk-xfs.md
Lines 51 (patched)
<https://reviews.apache.org/r/66975/#comment284369>
We should say something like:
```
Then the `--xfs_kill_containers` flag is set, the XFS Disk isolator will poll for soft limit violations at the interval given by the `--container_disk_watch_interval` flag.
```
- James Peach
On May 6, 2018, 3:03 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66975/
> -----------------------------------------------------------
>
> (Updated May 6, 2018, 3:03 p.m.)
>
>
> Review request for mesos, Greg Mann and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Add to disk xfs isolator page
> - Add to the upgrades page
>
>
> Diffs
> -----
>
> docs/isolators/disk-xfs.md e56f6473d0bffc6574b9abdfc9843961c2d0b688
> docs/upgrades.md 512d5d9067812cf73351f5be6bd244856a36e1dc
>
>
> Diff: https://reviews.apache.org/r/66975/diff/1/
>
>
> Testing
> -------
>
> N/A Documentation
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66975: Add documentation for the
xfs-kill-containers flag.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66975/#review202526
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66975]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 6, 2018, 3:03 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66975/
> -----------------------------------------------------------
>
> (Updated May 6, 2018, 3:03 p.m.)
>
>
> Review request for mesos, Greg Mann and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Add to disk xfs isolator page
> - Add to the upgrades page
>
>
> Diffs
> -----
>
> docs/isolators/disk-xfs.md e56f6473d0bffc6574b9abdfc9843961c2d0b688
> docs/upgrades.md 512d5d9067812cf73351f5be6bd244856a36e1dc
>
>
> Diff: https://reviews.apache.org/r/66975/diff/1/
>
>
> Testing
> -------
>
> N/A Documentation
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66975: Add documentation for the
xfs-kill-containers flag.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66975/#review202525
-----------------------------------------------------------
PASS: Mesos patch 66975 was successfully built and tested.
Reviews applied: `['66975']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66975
- Mesos Reviewbot Windows
On May 6, 2018, 3:03 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66975/
> -----------------------------------------------------------
>
> (Updated May 6, 2018, 3:03 p.m.)
>
>
> Review request for mesos, Greg Mann and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - Add to disk xfs isolator page
> - Add to the upgrades page
>
>
> Diffs
> -----
>
> docs/isolators/disk-xfs.md e56f6473d0bffc6574b9abdfc9843961c2d0b688
> docs/upgrades.md 512d5d9067812cf73351f5be6bd244856a36e1dc
>
>
> Diff: https://reviews.apache.org/r/66975/diff/1/
>
>
> Testing
> -------
>
> N/A Documentation
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66975: Add documentation for the
xfs_kill_containers flag.
Posted by Harold Dost <h....@criteo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66975/
-----------------------------------------------------------
(Updated May 6, 2018, 3:03 p.m.)
Review request for mesos, Greg Mann and James Peach.
Bugs: MESOS-6575
https://issues.apache.org/jira/browse/MESOS-6575
Repository: mesos
Description
-------
- Add to disk xfs isolator page
- Add to the upgrades page
Diffs
-----
docs/isolators/disk-xfs.md e56f6473d0bffc6574b9abdfc9843961c2d0b688
docs/upgrades.md 512d5d9067812cf73351f5be6bd244856a36e1dc
Diff: https://reviews.apache.org/r/66975/diff/1/
Testing (updated)
-------
N/A Documentation
Thanks,
Harold Dost