You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/27 17:16:43 UTC

[GitHub] [beam] amaliujia edited a comment on pull request #13094: [BEAM-5570] Update javacc dependency

amaliujia edited a comment on pull request #13094:
URL: https://github.com/apache/beam/pull/13094#issuecomment-717395399


   I will support the idea that not to upgrade JavaCC for BeamSQL. The primary reason is Calcite pins itself at JavaCC 4.0 as well. So keeping JavaCC at 4.0 for BeamSQL will maintain compatibility. 
   
   
   Thus this PR LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org