[GitHub] [spark] yaooqinn commented on a diff in pull request #42502: [SPARK-44802][INFRA][FOLLOWUP] Fix to consider JIRA_ACCESS_TOKEN in precheck conditions

["yaooqinn (via GitHub)" <gi...@apache.org>]

yaooqinn commented on code in PR #42502:
URL: https://github.com/apache/spark/pull/42502#discussion_r1295582096


##########
dev/merge_spark_pr.py:
##########
@@ -494,8 +494,12 @@ def main():
     original_head = get_current_ref()
 
     # Check this up front to avoid failing the JIRA update at the very end
-    if not JIRA_USERNAME or not JIRA_PASSWORD:
-        continue_maybe("The env-vars JIRA_USERNAME and/or JIRA_PASSWORD are not set. Continue?")
+    if not JIRA_ACCESS_TOKEN and (not JIRA_USERNAME or not JIRA_PASSWORD):
+        msg = (
+            "The env-vars JIRA_ACCESS_TOKEN, JIRA_USERNAME and/or JIRA_PASSWORD are not set. "
+            + "Continue?"

Review Comment:
   ```suggestion
               "The env-vars JIRA_ACCESS_TOKEN or JIRA_USERNAME/JIRA_PA
   SSWORD are not set. Continue?"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org