[GitHub] [hbase] apurtell commented on a change in pull request #3767: HBASE-26371 Prioritize meta region move over other region moves in region_mover

[GitBox <gi...@apache.org>]

apurtell commented on a change in pull request #3767:
URL: https://github.com/apache/hbase/pull/3767#discussion_r732257175



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java
##########
@@ -284,21 +286,43 @@ public RegionMover build() throws IOException {
    */
   public boolean load() throws ExecutionException, InterruptedException, TimeoutException {
     ExecutorService loadPool = Executors.newFixedThreadPool(1);
-    Future<Boolean> loadTask = loadPool.submit(() -> {
+    Future<Boolean> loadTask = loadPool.submit(getRegionsMovePlan(true));

Review comment:
       Rather than have a boolean parameter, which makes the code a little hard to understand, consider two methods (perhaps mostly sharing functionality via a common sibling method), one for making a META region move plan, if meta needs to be moved, and another for making a region move plan that excludes meta. E.g. getSystemRegionsMovePlan() vs getRegionsMovePlan(). Will make it a little easier to understand. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org