You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2017/10/09 08:22:38 UTC

[GitHub] flink pull request #4785: [FLINK-7776][TableAPI & SQL] do not emit duplicate...

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4785#discussion_r143405406
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala ---
    @@ -129,17 +129,19 @@ class GroupAggProcessFunction(
           state.update(accumulators)
           cntState.update(inputCnt)
     
    -      // if this was not the first row and we have to emit retractions
    -      if (generateRetraction && !firstRow) {
    +      // if this was not the first row and we may have to emit retractions
    --- End diff --
    
    I'd remove the `"and we may have to emit retractions"` part of the comment as this is not reflected by the condition.


---