You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/08/13 00:57:49 UTC
[Impala-ASF-CR] Revert "IMPALA-8791: Handle the case where there is no fragment scheduled on"
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14052
Change subject: Revert "IMPALA-8791: Handle the case where there is no fragment scheduled on"
......................................................................
Revert "IMPALA-8791: Handle the case where there is no fragment scheduled on"
This reverts commit 760169edcbca438c5964380a604b6c271c6bd1a3.
Change-Id: Id20cf3581995f450de6f491e7874cbcf23b52cda
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/scheduling/admission-controller-test.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/query-schedule.cc
M be/src/scheduling/query-schedule.h
M be/src/scheduling/scheduler.cc
M be/src/scheduling/scheduler.h
M fe/src/main/java/org/apache/impala/planner/Planner.java
M testdata/workloads/functional-query/queries/QueryTest/dedicated-coord-mem-estimates.test
12 files changed, 123 insertions(+), 154 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/14052/1
--
To view, visit http://gerrit.cloudera.org:8080/14052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id20cf3581995f450de6f491e7874cbcf23b52cda
Gerrit-Change-Number: 14052
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-8791: Handle the case where there is no fragment scheduled on"
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14052 )
Change subject: Revert "IMPALA-8791: Handle the case where there is no fragment scheduled on"
......................................................................
Revert "IMPALA-8791: Handle the case where there is no fragment scheduled on"
This reverts commit 760169edcbca438c5964380a604b6c271c6bd1a3.
Change-Id: Id20cf3581995f450de6f491e7874cbcf23b52cda
Reviewed-on: http://gerrit.cloudera.org:8080/14052
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/scheduling/admission-controller-test.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/query-schedule.cc
M be/src/scheduling/query-schedule.h
M be/src/scheduling/scheduler.cc
M be/src/scheduling/scheduler.h
M fe/src/main/java/org/apache/impala/planner/Planner.java
M testdata/workloads/functional-query/queries/QueryTest/dedicated-coord-mem-estimates.test
12 files changed, 123 insertions(+), 154 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id20cf3581995f450de6f491e7874cbcf23b52cda
Gerrit-Change-Number: 14052
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-8791: Handle the case where there is no fragment scheduled on"
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14052 )
Change subject: Revert "IMPALA-8791: Handle the case where there is no fragment scheduled on"
......................................................................
Patch Set 1: Verified+1 Code-Review+2
This was the latest commit, so should be safe to revert.
--
To view, visit http://gerrit.cloudera.org:8080/14052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id20cf3581995f450de6f491e7874cbcf23b52cda
Gerrit-Change-Number: 14052
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Aug 2019 01:00:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-8791: Handle the case where there is no fragment scheduled on"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14052 )
Change subject: Revert "IMPALA-8791: Handle the case where there is no fragment scheduled on"
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4227/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id20cf3581995f450de6f491e7874cbcf23b52cda
Gerrit-Change-Number: 14052
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Aug 2019 01:38:10 +0000
Gerrit-HasComments: No