You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2025/12/22 20:23:43 UTC

Re: [PR] HDDS-13415. Support DeleteRange operation as part of the rocksdb batch write [ozone]

szetszwo commented on code in PR #8774:
URL: https://github.com/apache/ozone/pull/8774#discussion_r2641140779


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBBatchOperation.java:
##########
@@ -125,6 +131,195 @@ public String toString() {
       return array != null ? bytes2String(array)
           : bytes2String(asReadOnlyByteBuffer());
     }
+
+    // This method mimics the ByteWiseComparator in RocksDB.
+    @Override
+    public int compareTo(RDBBatchOperation.Bytes that) {

Review Comment:
   @swamirishi , Let's just use ByteWiseComparator.  There is no reason to implemant a new compareTo method.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org