[jira] [Commented] (AIRFLOW-5806) Simplify the xcom table

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961999#comment-16961999 ] 

ASF GitHub Bot commented on AIRFLOW-5806:
-----------------------------------------

Fokko commented on pull request #6463: [AIRFLOW-5806] Simplify the xcom table
URL: https://github.com/apache/airflow/pull/6463
 
 
   Remove the id column, since it isn't used anywhere.
   
   Checked migrations in both directions. Using the sqlite cli:
   
   ```
   sqlite> .fullschema
   
   ... Removed unrelated stuff ...
   
   CREATE TABLE IF NOT EXISTS "xcom" (
   	"key" VARCHAR(512) NOT NULL, 
   	value BLOB, 
   	timestamp DATETIME NOT NULL, 
   	execution_date DATETIME NOT NULL, 
   	task_id VARCHAR(250) NOT NULL, 
   	dag_id VARCHAR(250) NOT NULL, 
   	CONSTRAINT pk_xcom PRIMARY KEY (dag_id, task_id, "key", execution_date)
   );
   /* No STAT tables available */
   sqlite> ^C
   ```
   
   Downgrade:
   ```
   root@73f8f875e3cb:/opt/airflow/airflow# alembic downgrade 004c1210f153
   /opt/airflow/airflow/models/dagbag.py:21: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
     import imp
   INFO  [alembic.runtime.migration] Context impl SQLiteImpl.
   INFO  [alembic.runtime.migration] Will assume non-transactional DDL.
   INFO  [alembic.runtime.migration] Running downgrade bbf4a7ad0465 -> 004c1210f153, Remove id column from xcom
   ```
   
   
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-5806\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5806
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Simplify the xcom table
> -----------------------
>
>                 Key: AIRFLOW-5806
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5806
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: xcom
>    Affects Versions: 1.10.5
>            Reporter: Fokko Driesprong
>            Assignee: Fokko Driesprong
>            Priority: Major
>             Fix For: 2.0.0
>
>
> The id column isn't used anywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)