[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35697: [SPARK-38213][CORE] Adding KafkaSink Metrics feature

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #35697:
URL: https://github.com/apache/spark/pull/35697#discussion_r817335821



##########
File path: core/pom.xml
##########
@@ -501,7 +501,11 @@
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-crypto</artifactId>
     </dependency>
-
+    <dependency>
+      <groupId>org.apache.kafka</groupId>
+      <artifactId>kafka-clients</artifactId>
+      <version>${kafka.version}</version>
+    </dependency>

Review comment:
       Thank you for pinging me, but Apache Spark module architecture doesn't allow this, @senthh .
   Please note that Kafka modules are `external`.
   https://github.com/apache/spark/blob/f14f6d6dea6c1a8099604596b623f4a191feaa5c/pom.xml#L104-L107
   
   Please try a different way by respecting the existing module architecture.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org