[jira] [Commented] (THRIFT-5061) Pin Ruby's rack version to 2.0.8

["Kengo Seki (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013473#comment-17013473 ] 

Kengo Seki commented on THRIFT-5061:
------------------------------------

Sure, thanks for reviewing and merging!

> Pin Ruby's rack version to 2.0.8
> --------------------------------
>
>                 Key: THRIFT-5061
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5061
>             Project: Thrift
>          Issue Type: Test
>          Components: Ruby - Library
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>            Priority: Major
>             Fix For: 0.14.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Recently released rack 2.1.0 introduced the following unit test failures in the Ruby library.
> {code}
> rspec ./spec/thin_http_server_spec.rb:99 # Thrift::ThinHTTPServer::RackApplication 404 response receives a non-POST
> rspec ./spec/thin_http_server_spec.rb:105 # Thrift::ThinHTTPServer::RackApplication 404 response receives a header other than application/x-thrift
> rspec ./spec/thin_http_server_spec.rb:132 # Thrift::ThinHTTPServer::RackApplication 200 response status code 200
> {code}
> It seems rack 2.1.0 returns status code 500 in some cases, while v2.0.8 or lower returns 404 in such cases. I'm not sure if it's a bug of rack yet, but I'd like to pin its version to 2.0.8 as a workaround for the time being.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)