You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/14 04:38:10 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6428: net/tcp: d_appdata should remove the tcp specific option field

anchao opened a new pull request, #6428:
URL: https://github.com/apache/incubator-nuttx/pull/6428

   ## Summary
   
   net/tcp: d_appdata should remove the tcp specific option field
   
   applicate data field should not touch data of IP layer
   
   Signed-off-by: chao.an <an...@xiaomi.com>
   
   ## Impact
   
   N/A
   
   ## Testing
   
   TCP streaming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6428: net/tcp: d_appdata should remove the tcp specific option field

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6428:
URL: https://github.com/apache/incubator-nuttx/pull/6428


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6428: net/tcp: d_appdata should remove the tcp specific option field

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6428:
URL: https://github.com/apache/incubator-nuttx/pull/6428#discussion_r897039891


##########
net/tcp/tcp_input.c:
##########
@@ -629,6 +629,17 @@ static void tcp_input(FAR struct net_driver_s *dev, uint8_t domain,
 
   dev->d_len -= (len + iplen);
 
+  /* d_appdata should remove the tcp specific option field. */
+
+  if ((tcp->tcpoffset & 0xf0) > 0x50)
+    {
+      len = ((tcp->tcpoffset >> 4) - 5) << 2;
+      if (len > 0 && dev->d_len >= len)

Review Comment:
   I think `len` is always `> 0` if we are reaching here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org