[GitHub] [kafka] ijuma commented on a diff in pull request #13579: KAFKA-14904: Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

["ijuma (via GitHub)" <gi...@apache.org>]

ijuma commented on code in PR #13579:
URL: https://github.com/apache/kafka/pull/13579#discussion_r1167627192


##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -396,8 +397,14 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
           } else if (txnMetadata.producerEpoch != producerEpoch) {
             Left(Errors.PRODUCER_FENCED)
           } else if (txnMetadata.pendingTransitionInProgress) {
-            // return a retriable exception to let the client backoff and retry
-            Left(Errors.CONCURRENT_TRANSACTIONS)
+            // If we are in the produce path, we want to avoid OutOfOrderSequence errors if the added partition is pending.
+            // TODO: Part 2 of KIP-890 will always start transactions with sequence 0, so we enforce that and avoid this workaround.

Review Comment:
   We generally avoid `TODO` in the code - they always go stale and give the impression that something is not complete. The comment itself is fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org