You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Stefan Bodewig <bo...@apache.org> on 2012/07/08 21:16:52 UTC
[compress] encoding parameter in ArchiveStreamFactory (was Re: svn commit: r1358626)
On 2012-07-08, sebb wrote:
> On 7 July 2012 20:34, <bo...@apache.org> wrote:
>> Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/ArchiveStreamFactory.java
>>+ private String entryEncoding = null;
> The class is currently tagged as:
> * @Immutable
> This breaks the contract.
> Can the field be made final?
If we make it a constructor arg rather than a property.
> Or turned into a parameter?
This is slightly less convenient, I'm on the fence here. Jukka?
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org