[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2418: [KYUUBI #2346] [Improvement] Simplify FlinkProcessBuilder with java executable

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #2418:
URL: https://github.com/apache/incubator-kyuubi/pull/2418#discussion_r856090952


##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FlinkSQLEngine.scala:
##########
@@ -125,6 +124,20 @@ object FlinkSQLEngine extends Logging {
     }
   }
 
+  def executeConfigShell(): Unit = {
+    val flinkHome = System.getenv("FLINK_HOME")
+    require(flinkHome != null, s"FLINK_HOME is null")
+    val commands = Seq("/bin/bash", s"$flinkHome/bin/config.sh")
+    val pb = new ProcessBuilder(commands: _*)
+    val process = pb.start()

Review Comment:
   `bash config.sh` is different from `source config.sh`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org