You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "dipankr (via GitHub)" <gi...@apache.org> on 2023/04/16 11:33:17 UTC
[GitHub] [eventmesh] dipankr opened a new pull request, #3743: #2979 replaced 'get + null check + creating empty list'
dipankr opened a new pull request, #3743:
URL: https://github.com/apache/eventmesh/pull/3743
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #2979.
### Motivation
we were doing a get, then a null check, if null then we were creating an empty list and inserting that in a map.
### Modifications
replaced 'get + null check + creating empty list' with computeIfAbsent
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3743: [ISSUE #2979] replaced 'get + null check + creating empty list'
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3743:
URL: https://github.com/apache/eventmesh/pull/3743#issuecomment-1510936627
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3743?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3743](https://codecov.io/gh/apache/eventmesh/pull/3743?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13dabae) into [master](https://codecov.io/gh/apache/eventmesh/commit/58b5ab715f27cf67b069f62beb6254b7ec20cdb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58b5ab7) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 13dabae differs from pull request most recent head 6eb4414. Consider uploading reports for the commit 6eb4414 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3743 +/- ##
============================================
- Coverage 13.76% 13.76% -0.01%
- Complexity 1291 1292 +1
============================================
Files 571 571
Lines 29234 29221 -13
Branches 2883 2869 -14
============================================
- Hits 4024 4022 -2
+ Misses 24836 24827 -9
+ Partials 374 372 -2
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...http/processor/LocalUnSubscribeEventProcessor.java](https://codecov.io/gh/apache/eventmesh/pull/3743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvTG9jYWxVblN1YnNjcmliZUV2ZW50UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [8 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3743/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3743: [ISSUE #2979] replaced 'get + null check + creating empty list'
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3743:
URL: https://github.com/apache/eventmesh/pull/3743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org