You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2025/04/24 09:55:10 UTC
[PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
nvazquez opened a new pull request, #10770:
URL: https://github.com/apache/cloudstack/pull/10770
### Description
This PR adds a filter by hosts on the Vmware to KVM migration tool to reduce the timeout observed while listing VMs on a datacenter.
It was originally added by PR: #9925 but reverted as it caused unintended regression affecting the VM console access (#10634)
Fixes: #9782
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2852438597
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2874309856
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#discussion_r2066189893
##########
plugins/hypervisors/vmware/src/main/java/org/apache/cloudstack/api/command/admin/zone/ListVmwareDcHostsCmd.java:
##########
@@ -0,0 +1,138 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.zone;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.hypervisor.Hypervisor;
+import com.cloud.hypervisor.vmware.VmwareDatacenterService;
+import com.cloud.hypervisor.vmware.mo.HostMO;
+import com.cloud.user.Account;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseListCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.HostResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.api.response.VmwareDatacenterResponse;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang3.StringUtils;
+
+import javax.inject.Inject;
+import java.util.ArrayList;
+import java.util.List;
+
+@APICommand(name = "listVmwareDcHosts", responseObject = HostResponse.class,
Review Comment:
Should there be default access defined, unless this is for admin only @nvazquez ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2830419321
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2830650963
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2831882911
<b>[SF] Trillian test result (tid-13159)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51831 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10770-t13159-vmware-70u3.zip
Smoke tests completed. 130 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_role_account_acls | `Failure` | 3.55 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | `Failure` | 3.54 | test_dynamicroles.py
test_01_events_resource | `Error` | 320.53 | test_events_resource.py
test_01_events_resource | `Error` | 320.54 | test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations | `Error` | 117.94 | test_network_permissions.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2875865700
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#discussion_r2059657302
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##########
@@ -1615,26 +1631,81 @@ public List<UnmanagedInstanceTO> listVMsInDatacenter(ListVmwareDcVmsCmd cmd) {
username = vmwareDc.getUser();
password = vmwareDc.getPassword();
}
+ VcenterData vmwaredc = new VcenterData(vcenter, datacenterName, username, password);
+ return vmwaredc;
+ }
+
+ private static VmwareContext getVmwareContext(String vcenter, String username, String password) throws Exception {
+ s_logger.debug(String.format("Connecting to the VMware vCenter %s", vcenter));
+ String serviceUrl = String.format("https://%s/sdk/vimService", vcenter);
+ VmwareClient vimClient = new VmwareClient(vcenter);
+ vimClient.connect(serviceUrl, username, password);
+ return new VmwareContext(vimClient, vcenter);
+ }
+
+ @Override
+ public List<UnmanagedInstanceTO> listVMsInDatacenter(ListVmwareDcVmsCmd cmd) {
+ VcenterData vmwareDC = getVcenterData(cmd);
+ String vcenter = vmwareDC.vcenter;
+ String username = vmwareDC.username;
+ String password = vmwareDC.password;
+ String datacenterName = vmwareDC.datacenterName;
+ String keyword = cmd.getKeyword();
+ String esxiHostName = cmd.getHostName();
try {
- s_logger.debug(String.format("Connecting to the VMware datacenter %s at vCenter %s to retrieve VMs",
- datacenterName, vcenter));
- String serviceUrl = String.format("https://%s/sdk/vimService", vcenter);
- VmwareClient vimClient = new VmwareClient(vcenter);
- vimClient.connect(serviceUrl, username, password);
- VmwareContext context = new VmwareContext(vimClient, vcenter);
-
- DatacenterMO dcMo = new DatacenterMO(context, datacenterName);
- ManagedObjectReference dcMor = dcMo.getMor();
- if (dcMor == null) {
- String msg = String.format("Unable to find VMware datacenter %s in vCenter %s",
- datacenterName, vcenter);
- s_logger.error(msg);
- throw new InvalidParameterValueException(msg);
+ VmwareContext context = getVmwareContext(vcenter, username, password);
+ DatacenterMO dcMo = getDatacenterMO(context, vcenter, datacenterName);
Review Comment:
should check for dcMo null (in case wrong datacenter name)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2852338112
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2830626966
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2876161280
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2830052528
<b>[SF] Trillian test result (tid-13127)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 79615 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10770-t13127-vmware-70u3.zip
Smoke tests completed. 127 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_role_account_acls | `Failure` | 3.97 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | `Failure` | 3.33 | test_dynamicroles.py
test_01_events_resource | `Error` | 355.18 | test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations | `Error` | 122.44 | test_network_permissions.py
test_01_restore_vm | `Error` | 3607.45 | test_restore_vm.py
test_02_restore_vm_allocated_root | `Error` | 10.30 | test_restore_vm.py
test_12_destroy_cpvm | `Error` | 6.36 | test_ssvm.py
test_01_deploy_vm_on_specific_host | `Error` | 19.06 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 3607.06 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 2.57 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.56 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 15.80 | test_vm_deployment_planner.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2827035913
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2827333712
@blueorangutan test ol8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2873113156
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2827039837
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2827248551
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#discussion_r2059661372
##########
plugins/hypervisors/vmware/src/main/java/org/apache/cloudstack/api/command/admin/zone/ListVmwareDcHostsCmd.java:
##########
@@ -0,0 +1,138 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.zone;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.hypervisor.Hypervisor;
+import com.cloud.hypervisor.vmware.VmwareDatacenterService;
+import com.cloud.hypervisor.vmware.mo.HostMO;
+import com.cloud.user.Account;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseListCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.HostResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.api.response.VmwareDatacenterResponse;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang3.StringUtils;
+
+import javax.inject.Inject;
+import java.util.ArrayList;
+import java.util.List;
+
+@APICommand(name = "listVmwareDcHosts", responseObject = HostResponse.class,
+ description = "Lists the Hosts in a Vmware Datacenter",
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class ListVmwareDcHostsCmd extends BaseListCmd implements ListVmwareDcItems {
+
+ @Inject
+ public VmwareDatacenterService _vmwareDatacenterService;
+
+ @Parameter(name = ApiConstants.EXISTING_VCENTER_ID,
+ type = CommandType.UUID,
+ entityType = VmwareDatacenterResponse.class,
+ description = "UUID of a linked existing vCenter")
+ private Long existingVcenterId;
+
+ @Parameter(name = ApiConstants.VCENTER,
+ type = CommandType.STRING,
+ description = "The name/ip of vCenter. Make sure it is IP address or full qualified domain name for host running vCenter server.")
+ private String vcenter;
+
+ @Parameter(name = ApiConstants.DATACENTER_NAME, type = CommandType.STRING, description = "Name of Vmware datacenter.")
+ private String datacenterName;
+
+ @Parameter(name = ApiConstants.USERNAME, type = CommandType.STRING, description = "The Username required to connect to resource.")
+ private String username;
+
+ @Parameter(name = ApiConstants.PASSWORD, type = CommandType.STRING, description = "The password for specified username.")
+ private String password;
+
+ public String getVcenter() {
+ return vcenter;
+ }
+
+ public String getUsername() {
+ return username;
+ }
+
+ public String getPassword() {
+ return password;
+ }
+
+ public String getDatacenterName() {
+ return datacenterName;
+ }
+
+ public Long getExistingVcenterId() {
+ return existingVcenterId;
+ }
+
+ @Override
+ public void execute() throws ResourceUnavailableException, InsufficientCapacityException, ServerApiException, ConcurrentOperationException, ResourceAllocationException, NetworkRuleConflictException {
+ checkParameters();
+ try {
+ List<HostMO> hosts = _vmwareDatacenterService.listHostsInDatacenter(this);
+ ListResponse<HostResponse> response = new ListResponse<>();
+ List<HostResponse> baseResponseList = new ArrayList<>();
+ if (CollectionUtils.isNotEmpty(hosts)) {
+ for (HostMO vmwareHost : hosts) {
+ HostResponse resp = createHostResponse(vmwareHost);
+ baseResponseList.add(resp);
+ }
+ }
+ response.setResponses(baseResponseList, baseResponseList.size());
+ response.setResponseName(getCommandName());
+ setResponseObject(response);
+ } catch (Exception e) {
+ String errorMsg = String.format("Error retrieving VMs from Vmware VC: %s", e.getMessage());
Review Comment:
```suggestion
String errorMsg = String.format("Error retrieving Hosts from VMware VC: %s", e.getMessage());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2874045503
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2830421194
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2852334550
Hi @sureshanaparti @DaanHoogland @rohityadavcloud I could improve the listing reducing the time significantly by excluding the disks and NICs information on the initial listing and then obtaining them when the user selects the VM (I have updated the PR description to explain the new behavior). Can you please re-review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2874410382
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2875860151
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #10770: [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM
URL: https://github.com/apache/cloudstack/pull/10770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#discussion_r2059657302
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##########
@@ -1615,26 +1631,81 @@ public List<UnmanagedInstanceTO> listVMsInDatacenter(ListVmwareDcVmsCmd cmd) {
username = vmwareDc.getUser();
password = vmwareDc.getPassword();
}
+ VcenterData vmwaredc = new VcenterData(vcenter, datacenterName, username, password);
+ return vmwaredc;
+ }
+
+ private static VmwareContext getVmwareContext(String vcenter, String username, String password) throws Exception {
+ s_logger.debug(String.format("Connecting to the VMware vCenter %s", vcenter));
+ String serviceUrl = String.format("https://%s/sdk/vimService", vcenter);
+ VmwareClient vimClient = new VmwareClient(vcenter);
+ vimClient.connect(serviceUrl, username, password);
+ return new VmwareContext(vimClient, vcenter);
+ }
+
+ @Override
+ public List<UnmanagedInstanceTO> listVMsInDatacenter(ListVmwareDcVmsCmd cmd) {
+ VcenterData vmwareDC = getVcenterData(cmd);
+ String vcenter = vmwareDC.vcenter;
+ String username = vmwareDC.username;
+ String password = vmwareDC.password;
+ String datacenterName = vmwareDC.datacenterName;
+ String keyword = cmd.getKeyword();
+ String esxiHostName = cmd.getHostName();
try {
- s_logger.debug(String.format("Connecting to the VMware datacenter %s at vCenter %s to retrieve VMs",
- datacenterName, vcenter));
- String serviceUrl = String.format("https://%s/sdk/vimService", vcenter);
- VmwareClient vimClient = new VmwareClient(vcenter);
- vimClient.connect(serviceUrl, username, password);
- VmwareContext context = new VmwareContext(vimClient, vcenter);
-
- DatacenterMO dcMo = new DatacenterMO(context, datacenterName);
- ManagedObjectReference dcMor = dcMo.getMor();
- if (dcMor == null) {
- String msg = String.format("Unable to find VMware datacenter %s in vCenter %s",
- datacenterName, vcenter);
- s_logger.error(msg);
- throw new InvalidParameterValueException(msg);
+ VmwareContext context = getVmwareContext(vcenter, username, password);
+ DatacenterMO dcMo = getDatacenterMO(context, vcenter, datacenterName);
Review Comment:
should check for dcMo null (in case wrong datacenter name)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2827053153
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10770?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.29%. Comparing base [(`55c8138`)](https://app.codecov.io/gh/apache/cloudstack/commit/55c8138a1a75a19ca61580dd4d610e1a05fc5dea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`16eab4d`)](https://app.codecov.io/gh/apache/cloudstack/commit/16eab4debce74ed741798aee262ad39cfefced2e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (55c8138) and HEAD (16eab4d). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (55c8138) | HEAD (16eab4d) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.19 #10770 +/- ##
=============================================
- Coverage 15.16% 4.29% -10.88%
=============================================
Files 5412 369 -5043
Lines 475033 29680 -445353
Branches 57963 5209 -52754
=============================================
- Hits 72048 1274 -70774
+ Misses 394930 28261 -366669
+ Partials 8055 145 -7910
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10770/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10770/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10770/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10770?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2852334777
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2873324320
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2876048736
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #10770: [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM
URL: https://github.com/apache/cloudstack/pull/10770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2830647935
@blueorangutan test ol8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware][UI] Fix Timeout listing Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2827338506
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2876339036
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2874050528
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2876335741
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2876158733
@blueorangutan test ol8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2873097696
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#discussion_r2085648470
##########
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/BaseMO.java:
##########
@@ -153,4 +168,66 @@ public int getCustomFieldKey(String morType, String fieldName) throws Exception
return cfmMo.getCustomFieldKey(morType, fieldName);
}
+
+ private static UnmanagedInstanceTO.PowerState convertPowerState(VirtualMachinePowerState powerState) {
+ return powerState == VirtualMachinePowerState.POWERED_ON ? UnmanagedInstanceTO.PowerState.PowerOn :
+ powerState == VirtualMachinePowerState.POWERED_OFF ? UnmanagedInstanceTO.PowerState.PowerOff : UnmanagedInstanceTO.PowerState.PowerUnknown;
+ }
+
+ protected List<UnmanagedInstanceTO> convertVmsObjectContentsToUnmanagedInstances(List<ObjectContent> ocs, String keyword) throws Exception {
Review Comment:
Thanks @DaanHoogland, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2874409009
@blueorangutan test ol8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2876566960
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2854217180
as this functionality was implemented in 4.19.2 (but with side effects) and thus would be a regression if not merged, I marked this as BLOCKER.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2854473755
<b>[SF] Trillian test result (tid-13205)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49843 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10770-t13205-vmware-70u3.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2852488006
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#issuecomment-2852484584
@blueorangutan test ol8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Vmware] Improve listing of Vmware Datacenter VMs for migration to KVM [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#discussion_r2074807686
##########
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/BaseMO.java:
##########
@@ -153,4 +168,66 @@ public int getCustomFieldKey(String morType, String fieldName) throws Exception
return cfmMo.getCustomFieldKey(morType, fieldName);
}
+
+ private static UnmanagedInstanceTO.PowerState convertPowerState(VirtualMachinePowerState powerState) {
+ return powerState == VirtualMachinePowerState.POWERED_ON ? UnmanagedInstanceTO.PowerState.PowerOn :
+ powerState == VirtualMachinePowerState.POWERED_OFF ? UnmanagedInstanceTO.PowerState.PowerOff : UnmanagedInstanceTO.PowerState.PowerUnknown;
+ }
+
+ protected List<UnmanagedInstanceTO> convertVmsObjectContentsToUnmanagedInstances(List<ObjectContent> ocs, String keyword) throws Exception {
Review Comment:
complexity of this method is a bit high, would be nice to modularise it a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org