You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Yuvraj-cyborg (via GitHub)" <gi...@apache.org> on 2025/11/14 08:51:07 UTC

[PR] Fix: Respect enable_ident_normalization setting in table registration [datafusion]

Yuvraj-cyborg opened a new pull request, #18696:
URL: https://github.com/apache/datafusion/pull/18696

   Description:
   
   Fixes inconsistency where table registration methods (`[register_table]`, `[register_csv]`, etc.) always normalized identifiers to lowercase, ignoring the `[enable_ident_normalization]` configuration.
   
   Problem
   When `[enable_ident_normalization=false]` :
   
   `[register_csv("DATA", ...)]` normalized the name to "data"
   `SELECT * FROM DATA looked for "DATA"`
   Result - [table 'DATA' not found] error
   
   Root Cause
   `[TableReference::parse_str()]` hardcoded `[ignore_case=false]` , forcing normalization regardless of session settings.
   
   Solution
   Introduced `ResolveTableReference` trait to parse table references respecting the session's `[enable_ident_normalization]` setting. Updated `[register_table()]`, `[deregister_table()]`, and `[table_exist()]` to use this trait.
   
   Changes :
   - Added `ResolveTableReference` trait for context-aware table reference parsing.
   - Modified table registration/lookup methods to respect normalization settings.
   - Added test example demonstrating the fix.
   
   ```
   cargo run --example test_ident_normalization
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix: Respect enable_ident_normalization setting in table registration [datafusion]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm closed pull request #18696: Fix: Respect enable_ident_normalization setting in table registration
URL: https://github.com/apache/datafusion/pull/18696


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix: Respect enable_ident_normalization setting in table registration [datafusion]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #18696:
URL: https://github.com/apache/datafusion/pull/18696#issuecomment-3533723698

   @Yuvraj-cyborg I'm not sure if this could be fixed without big impact on the public API or behaviour change. There is also a valid workaround. I will close relevant issue for now 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix: Respect enable_ident_normalization setting in table registration [datafusion]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #18696:
URL: https://github.com/apache/datafusion/pull/18696#issuecomment-3532031843

   I guess this PR addresses #18675, it would be great if PR description follows predefined template 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org