[GitHub] [camel-k] tadayosi commented on a diff in pull request #3171: fix #2835 address comments

[GitBox <gi...@apache.org>]

tadayosi commented on code in PR #3171:
URL: https://github.com/apache/camel-k/pull/3171#discussion_r843429641


##########
pkg/builder/project.go:
##########
@@ -91,6 +94,16 @@ func generateJavaKeystore(ctx *builderContext) error {
 	return jvm.GenerateKeystore(ctx.C, ctx.Path, ctx.Maven.TrustStoreName, ctx.Maven.TrustStorePass, certsData)
 }
 
+func mergeSecrets(secrets []corev1.SecretKeySelector, secret *corev1.SecretKeySelector) []corev1.SecretKeySelector {
+	if secrets == nil && secret == nil {

Review Comment:
   Is this check necessary?  `secrets == nil`
   I think it's always safe to assume a slice is not nil in Go.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org