[GitHub] [fineract] ptuomola commented on pull request #1186: FINERACT-1052 global config for Loan OverPayment

[GitBox <gi...@apache.org>]

ptuomola commented on pull request #1186:
URL: https://github.com/apache/fineract/pull/1186#issuecomment-663814472


   Hi
   
   My suggestion on this would be:
   - The current behaviour should be kept as the default - i.e. without a configuration present in the database, the same behaviour should remain (overpayments allowed)
   - The default configuration added to this should also keep the current behaviour as-is - i.e. the default Flyway script should add the flag as true
   - The existing integration tests should be kept-as is and they should test the current behaviour
   - We should create a new integration test (or multiple tests) to test the scenario where overpayments are not allowed. These tests should first set the flag to disable overpayments, then carry out the tests to confirm that overpayments fail in different scenarios, and then reset the flag back to enabling overpayments
   
   That way we a) preserve the current functionality for those who are relying on it, b) preserve the tests that test the current functionality, and c) add the ability to disable the overpayments and the relevant tests for this
   
   Personally I'm a bit surprised that we want to do this as a global configuration - wouldn't it make more sense to configure this per-product? But the original JIRA / requirements docs are very focused on making this a global setting...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org