You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2019/11/25 20:48:53 UTC
[GitHub] [hive] t3rmin4t0r commented on a change in pull request #853:
HIVE-22463 decimal64 multiplication
t3rmin4t0r commented on a change in pull request #853: HIVE-22463 decimal64 multiplication
URL: https://github.com/apache/hive/pull/853#discussion_r350414580
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
##########
@@ -1810,17 +1811,19 @@ private VectorExpression getDecimal64VectorExpressionForUdf(GenericUDF genericUd
}
VectorExpressionDescriptor.Mode childrenMode = getChildrenMode(mode, udfClass);
+ boolean dontScaleArguments = (genericUdf instanceof GenericUDFOPMultiply);
Review comment:
Move this up, make it final and check instead of the UDF check on #L1792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org