You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2010/09/03 19:56:32 UTC

[jira] Created: (AVRO-655) C & C++ 'dist' target should not run tests

C & C++ 'dist' target should not run tests
------------------------------------------

                 Key: AVRO-655
                 URL: https://issues.apache.org/jira/browse/AVRO-655
             Project: Avro
          Issue Type: Improvement
          Components: build
    Affects Versions: 1.4.0
            Reporter: Doug Cutting
            Assignee: Doug Cutting
             Fix For: 1.4.1


The intended semantics of the 'dist' target in build.sh is simply to create release artifacts, not to run tests.  The 'test' target should run tests.  Both C and C++ currently run tests under the 'dist' target.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-655) C & C++ 'dist' target should not run tests

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-655:
------------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Reviewed]
      Resolution: Fixed

I just committed this.

> C & C++ 'dist' target should not run tests
> ------------------------------------------
>
>                 Key: AVRO-655
>                 URL: https://issues.apache.org/jira/browse/AVRO-655
>             Project: Avro
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.4.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.4.1
>
>         Attachments: AVRO-655.patch
>
>
> The intended semantics of the 'dist' target in build.sh is simply to create release artifacts, not to run tests.  The 'test' target should run tests.  Both C and C++ currently run tests under the 'dist' target.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AVRO-655) C & C++ 'dist' target should not run tests

Posted by "Scott Banachowski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906567#action_12906567 ] 

Scott Banachowski commented on AVRO-655:
----------------------------------------

looks good to me

> C & C++ 'dist' target should not run tests
> ------------------------------------------
>
>                 Key: AVRO-655
>                 URL: https://issues.apache.org/jira/browse/AVRO-655
>             Project: Avro
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.4.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.4.1
>
>         Attachments: AVRO-655.patch
>
>
> The intended semantics of the 'dist' target in build.sh is simply to create release artifacts, not to run tests.  The 'test' target should run tests.  Both C and C++ currently run tests under the 'dist' target.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-655) C & C++ 'dist' target should not run tests

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-655:
------------------------------

    Attachment: AVRO-655.patch

Here's a patch that fixes this.  The generated tarballs contain identical content, but the overall time to build an Avro distribution on my laptop drops from around 4 minutes to around 2 minutes.

> C & C++ 'dist' target should not run tests
> ------------------------------------------
>
>                 Key: AVRO-655
>                 URL: https://issues.apache.org/jira/browse/AVRO-655
>             Project: Avro
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.4.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.4.1
>
>         Attachments: AVRO-655.patch
>
>
> The intended semantics of the 'dist' target in build.sh is simply to create release artifacts, not to run tests.  The 'test' target should run tests.  Both C and C++ currently run tests under the 'dist' target.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-655) C & C++ 'dist' target should not run tests

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-655:
------------------------------

    Status: Patch Available  (was: Open)

> C & C++ 'dist' target should not run tests
> ------------------------------------------
>
>                 Key: AVRO-655
>                 URL: https://issues.apache.org/jira/browse/AVRO-655
>             Project: Avro
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.4.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.4.1
>
>         Attachments: AVRO-655.patch
>
>
> The intended semantics of the 'dist' target in build.sh is simply to create release artifacts, not to run tests.  The 'test' target should run tests.  Both C and C++ currently run tests under the 'dist' target.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AVRO-655) C & C++ 'dist' target should not run tests

Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906323#action_12906323 ] 

Matt Massie commented on AVRO-655:
----------------------------------

+1

> C & C++ 'dist' target should not run tests
> ------------------------------------------
>
>                 Key: AVRO-655
>                 URL: https://issues.apache.org/jira/browse/AVRO-655
>             Project: Avro
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.4.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.4.1
>
>         Attachments: AVRO-655.patch
>
>
> The intended semantics of the 'dist' target in build.sh is simply to create release artifacts, not to run tests.  The 'test' target should run tests.  Both C and C++ currently run tests under the 'dist' target.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.