You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/23 02:50:42 UTC
[GitHub] [pulsar] Anonymitaet opened a new pull request #14811: [feature][workflow] Add Pulsar PR Naming Convention
Anonymitaet opened a new pull request #14811:
URL: https://github.com/apache/pulsar/pull/14811
Preview looks good:
<img width="1457" alt="image" src="https://user-images.githubusercontent.com/50226895/159614141-dc0f659c-8bdf-49dc-bd08-58c5f6561881.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #14811: [feature][workflow] Add Pulsar PR Naming Convention
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #14811:
URL: https://github.com/apache/pulsar/pull/14811#issuecomment-1075860707
@D-2-Ed @DaveDuggins @momo-jun could u PTAL? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a change in pull request #14811: [feature][workflow] Add Pulsar PR Naming Convention
Posted by GitBox <gi...@apache.org>.
momo-jun commented on a change in pull request #14811:
URL: https://github.com/apache/pulsar/pull/14811#discussion_r832815462
##########
File path: site2/website/contributing.md
##########
@@ -196,6 +196,10 @@ You'll then push to your branch on GitHub. Note: when updating your commit after
Navigate to the [Pulsar GitHub Repo](https://github.com/apache/pulsar) to create a pull request.
+> **Note**
+>
+> Vague, boring, and unclear PR titles decrease team efficiency and productivity. Good titles speed up the review process and increase search efficiency. PR titles should be engaging, easy to understand, and readable. For how to **write self​-explanatory PR titles** and **quality PR title examples**, see [[Guideline] Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#).
Review comment:
Regarding the word "quality", do you mean to "qualify" (as a verb) or "qualified" (as an adj.)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #14811: [feature][workflow] Add Pulsar PR Naming Convention
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #14811:
URL: https://github.com/apache/pulsar/pull/14811#discussion_r833832183
##########
File path: site2/website/contributing.md
##########
@@ -196,6 +196,10 @@ You'll then push to your branch on GitHub. Note: when updating your commit after
Navigate to the [Pulsar GitHub Repo](https://github.com/apache/pulsar) to create a pull request.
+> **Note**
+>
+> Vague, boring, and unclear PR titles decrease team efficiency and productivity. Good titles speed up the review process and increase search efficiency. PR titles should be engaging, easy to understand, and readable. For how to **write self​-explanatory PR titles** and **quality PR title examples**, see [[Guideline] Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#).
Review comment:
quality means "excellent" as an adjective
eg. quality work
quality chocolate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #14811: [feature][workflow] Add Pulsar PR Naming Convention
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #14811:
URL: https://github.com/apache/pulsar/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org