[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1707: chore: improve Upstream/CodeMirror

[GitBox <gi...@apache.org>]

qian0817 commented on a change in pull request #1707:
URL: https://github.com/apache/apisix-dashboard/pull/1707#discussion_r607564849



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -771,7 +775,12 @@ const UpstreamForm: React.FC<Props> = forwardRef(
                 {
                   label: formatMessage({ id: 'page.upstream.step.healthyCheck.active' }),
                   name: ['checks', 'active'],
-                  component: <ActiveHealthCheck />,
+                  component: (
+                    <>
+                      <ActiveHealthCheck />
+                      <Divider orientation="left" plain></Divider>

Review comment:
       collapse empty tag
   ```suggestion
                         <Divider orientation="left" plain/>
   ```

##########
File path: web/src/pages/Upstream/List.tsx
##########
@@ -136,12 +136,11 @@ const Page: React.FC = () => {
             <PlusOutlined />
             {formatMessage({ id: 'component.global.create' })}
           </Button>,
-          <Button type="primary" onClick={() => {
+          <Button type="default" onClick={() => {

Review comment:
       I think the original way looks better.
   At the same time, If really need to do this, also need to modify the style of other pages.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org