[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1104: Add validate for rowset writer

[GitBox <gi...@apache.org>]

yiguolei commented on a change in pull request #1104: Add validate for rowset writer
URL: https://github.com/apache/incubator-doris/pull/1104#discussion_r281513334
 
 

 ##########
 File path: be/src/olap/rowset/alpha_rowset_writer.cpp
 ##########
 @@ -200,6 +200,13 @@ RowsetSharedPtr AlphaRowsetWriter::build() {
     _current_rowset_meta->set_num_rows(_num_rows_written);
     _current_rowset_meta->set_creation_time(time(nullptr));
 
+    // validate rowset arguments before create rowset
+    bool ret = _validate_rowset();
+    if (!ret) {
+        LOG(WARNING) << "valiate rowset arguments failed";
+        return nullptr;
 
 Review comment:
   Just fatal here， because the caller may not check rowset == nullptr, and validate == false is an exception, should not happen.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org