You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "xichen01 (via GitHub)" <gi...@apache.org> on 2025/02/09 16:32:31 UTC

[PR] HDDS-12291. XceiverClientRatis allows adding ratis data stream configuration [ozone]

xichen01 opened a new pull request, #7842:
URL: https://github.com/apache/ozone/pull/7842

   ## What changes were proposed in this pull request?
   - XceiverClientRatis allows adding ratis data stream configuration.
   - According to the discussion at https://github.com/apache/ozone/pull/7645, we can skip `sendForward` by adding `hdds.ratis.raft.datastream.skip.send-forward` on the client side, thus avoiding an invalid ratis transaction (current streaming write will generate an invalid streamInit transaction)
   https://github.com/apache/ozone/blob/ab29a55eaea71db9f2912d2fc69c2865cad34af8/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java#L206-L226
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-12291
   
   ## How was this patch tested?
   Existing Tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12291. XceiverClientRatis allows adding ratis data stream configuration [ozone]

Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 merged PR #7842:
URL: https://github.com/apache/ozone/pull/7842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12291. XceiverClientRatis allows adding ratis data stream configuration [ozone]

Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #7842:
URL: https://github.com/apache/ozone/pull/7842#issuecomment-2649595153

   Thanks @xichen01 for the patch and @szetszwo for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-12291. XceiverClientRatis allows adding ratis data stream configuration [ozone]

Posted by "xichen01 (via GitHub)" <gi...@apache.org>.
xichen01 commented on PR #7842:
URL: https://github.com/apache/ozone/pull/7842#issuecomment-2646786897

   
   > Also I noticed that there is a `isStreamClientConfig` in `RatisHelper` (for `RaftClientConfigKeys.DataStream`), but it's only used for `createRaftServerProperties` (i.e. the datastream client to the peer DN). Should we also expose these to the client as well?
   
   The reason that I raised this PR was just to enable `raft.datastream.skip.send-forward` on the Ozone client, I'm not sure if there are any other `RaftClientConfigKeys.DataStream` configurations that need to be enabled on the Ozone client.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org