You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2009/05/13 13:48:45 UTC
[jira] Created: (DERBY-4228) Remove unused pre-i18n constructors in
BatchUpdateException
Remove unused pre-i18n constructors in BatchUpdateException
-----------------------------------------------------------
Key: DERBY-4228
URL: https://issues.apache.org/jira/browse/DERBY-4228
Project: Derby
Issue Type: Improvement
Components: Network Client
Affects Versions: 10.5.1.1
Reporter: Knut Anders Hatlen
Assignee: Knut Anders Hatlen
Priority: Minor
client.am.BatchUpdateException contains a number of unused constructors. There is a comment saying that they should be removed when i18n is complete. Since the i18n work on the client driver has been completed, and the constructors are no longer used, they should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4228) Remove unused pre-i18n constructors
in BatchUpdateException
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708982#action_12708982 ]
Kristian Waagan commented on DERBY-4228:
----------------------------------------
+1 from me.
Briefly looked at the patch, applied it and built Derby without errors after doing 'ant clobber'.
> Remove unused pre-i18n constructors in BatchUpdateException
> -----------------------------------------------------------
>
> Key: DERBY-4228
> URL: https://issues.apache.org/jira/browse/DERBY-4228
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Affects Versions: 10.5.1.1
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: constructors.diff
>
>
> client.am.BatchUpdateException contains a number of unused constructors. There is a comment saying that they should be removed when i18n is complete. Since the i18n work on the client driver has been completed, and the constructors are no longer used, they should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-4228) Remove unused pre-i18n constructors in
BatchUpdateException
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen closed DERBY-4228.
-------------------------------------
Resolution: Fixed
Fix Version/s: 10.6.0.0
Thanks, Kristian, for looking at the patch. All the regression tests ran cleanly, so I committed the patch to trunk with revision 774471.
> Remove unused pre-i18n constructors in BatchUpdateException
> -----------------------------------------------------------
>
> Key: DERBY-4228
> URL: https://issues.apache.org/jira/browse/DERBY-4228
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Affects Versions: 10.5.1.1
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Fix For: 10.6.0.0
>
> Attachments: constructors.diff
>
>
> client.am.BatchUpdateException contains a number of unused constructors. There is a comment saying that they should be removed when i18n is complete. Since the i18n work on the client driver has been completed, and the constructors are no longer used, they should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4228) Remove unused pre-i18n constructors in
BatchUpdateException
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-4228:
--------------------------------------
Attachment: constructors.diff
Here's a patch that removes the unused constructors.
> Remove unused pre-i18n constructors in BatchUpdateException
> -----------------------------------------------------------
>
> Key: DERBY-4228
> URL: https://issues.apache.org/jira/browse/DERBY-4228
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Affects Versions: 10.5.1.1
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: constructors.diff
>
>
> client.am.BatchUpdateException contains a number of unused constructors. There is a comment saying that they should be removed when i18n is complete. Since the i18n work on the client driver has been completed, and the constructors are no longer used, they should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.