[GitHub] [tvm] cconvey commented on a diff in pull request #12168: [hexagon][testing] sequential input tensors

[GitBox <gi...@apache.org>]

cconvey commented on code in PR #12168:
URL: https://github.com/apache/tvm/pull/12168#discussion_r929182340


##########
tests/python/contrib/test_hexagon/pytest_util.py:
##########
@@ -155,5 +166,15 @@ def create_populated_numpy_ndarray(
     elif type(itp) == TensorContentRandom:
         return np.random.random(input_shape).astype(dtype)
 
+    elif type(itp) == TensorContentSequentialCOrder:
+        a = np.empty(tuple(input_shape), dtype)
+
+        with np.nditer(a, op_flags=["writeonly"], order="C") as it:

Review Comment:
   > is should get a unittest
   
   I was on the fence about that.  I did test it manually, but I thought unit testing a little debug-assist like this might be overkill.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org