[GitHub] [incubator-druid] dclim commented on issue #7875: Make required S3 permissions consistent for pushing segments and task logs

[GitBox <gi...@apache.org>]

dclim commented on issue #7875: Make required S3 permissions consistent for pushing segments and task logs
URL: https://github.com/apache/incubator-druid/issues/7875#issuecomment-502768657
 
 
   @sashidhar thank you for your contribution! I left a few comments on your PR.
   
   Regarding the test class - I couldn't find one either. If you could create a simple one that exercises the functionality you added, that would be great.
   
   For the fallback - I think it's fine either way, whether you want to do it here or elsewhere. I'm thinking something really simple - like, wrapping the call in a try-catch and then retrying it one time without getting the bucket ACL / setting the object ACL if it fails. I'd add a log in the catch statement as well so that it's clear that the initial call failed and it's doing a fallback.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org