You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/29 09:43:52 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #10184: ARROW-12568: [C++][Compute] Fix nullptr deference when array contains no nulls

pitrou commented on a change in pull request #10184:
URL: https://github.com/apache/arrow/pull/10184#discussion_r622893252



##########
File path: cpp/src/arrow/compute/kernels/scalar_boolean.cc
##########
@@ -175,15 +175,24 @@ struct KleeneAnd : Commutative<KleeneAnd> {
     }
 
     if (right_true) {
-      GetBitmap(*out, 0).CopyFrom(GetBitmap(left, 0));
+      if (left.null_count == 0) {

Review comment:
       Yes, `GetNullCount()` will cache the null count value so that it's only computed once.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org