You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by ja...@apache.org on 2016/09/12 06:13:51 UTC
[1/3] couchdb-mango git commit: Set default limit to 25
Repository: couchdb-mango
Updated Branches:
refs/heads/master 1a4215678 -> 610ccb60d
Set default limit to 25
The docs claim the limit is 25 and this was the intention but this value
was never updated. The reason to set it at 25 is in case we add other
index types that are unable to stream results to the client (ie,
anything Lucene based). This allows us to maintain the same API across
all calls regardless of index type used.
COUCHDB-3143
Project: http://git-wip-us.apache.org/repos/asf/couchdb-mango/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-mango/commit/d8432c58
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-mango/tree/d8432c58
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-mango/diff/d8432c58
Branch: refs/heads/master
Commit: d8432c58a004141123e13a5af6dad78e3746399d
Parents: 1a42156
Author: Paul J. Davis <pa...@gmail.com>
Authored: Sun Sep 11 13:38:12 2016 -0500
Committer: Paul J. Davis <pa...@gmail.com>
Committed: Sun Sep 11 14:07:50 2016 -0500
----------------------------------------------------------------------
src/mango_cursor.hrl | 2 +-
src/mango_opts.erl | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/couchdb-mango/blob/d8432c58/src/mango_cursor.hrl
----------------------------------------------------------------------
diff --git a/src/mango_cursor.hrl b/src/mango_cursor.hrl
index f80c987..5706b6b 100644
--- a/src/mango_cursor.hrl
+++ b/src/mango_cursor.hrl
@@ -16,7 +16,7 @@
ranges,
selector,
opts,
- limit = 10000000000,
+ limit = 25,
skip = 0,
fields = undefined,
user_fun,
http://git-wip-us.apache.org/repos/asf/couchdb-mango/blob/d8432c58/src/mango_opts.erl
----------------------------------------------------------------------
diff --git a/src/mango_opts.erl b/src/mango_opts.erl
index 0c66a21..40e3504 100644
--- a/src/mango_opts.erl
+++ b/src/mango_opts.erl
@@ -93,7 +93,7 @@ validate_find({Props}) ->
{<<"limit">>, [
{tag, limit},
{optional, true},
- {default, 10000000000},
+ {default, 25},
{validator, fun is_non_neg_integer/1}
]},
{<<"skip">>, [
[3/3] couchdb-mango git commit: Merge remote-tracking branch
'cloudant/3143-fix-default-limit'
Posted by ja...@apache.org.
Merge remote-tracking branch 'cloudant/3143-fix-default-limit'
* cloudant/3143-fix-default-limit:
Fix test suite check for text indexes
Set default limit to 25
Project: http://git-wip-us.apache.org/repos/asf/couchdb-mango/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-mango/commit/610ccb60
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-mango/tree/610ccb60
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-mango/diff/610ccb60
Branch: refs/heads/master
Commit: 610ccb60d09bb2a730fa1af318c6ce558538d2ba
Parents: 1a42156 29b5944
Author: Jan Lehnardt <ja...@apache.org>
Authored: Mon Sep 12 08:13:29 2016 +0200
Committer: Jan Lehnardt <ja...@apache.org>
Committed: Mon Sep 12 08:13:29 2016 +0200
----------------------------------------------------------------------
src/mango_cursor.hrl | 2 +-
src/mango_opts.erl | 2 +-
test/mango.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
[2/3] couchdb-mango git commit: Fix test suite check for text indexes
Posted by ja...@apache.org.
Fix test suite check for text indexes
This was passing by accident on travis because the $CWD is set
differently so the test would always fail. If however you tried to run
the tests locally then it would fail. Obviously the test is just wrong
since we're moving the mango_cursor_text.erl file in rebar.config, and
not mango_cursor.erl which is required for every index type.
COUCHDB-3143
Project: http://git-wip-us.apache.org/repos/asf/couchdb-mango/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-mango/commit/29b59449
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-mango/tree/29b59449
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-mango/diff/29b59449
Branch: refs/heads/master
Commit: 29b59449dffea83470ec5c828a8ab2e8c6504a65
Parents: d8432c5
Author: Paul J. Davis <pa...@gmail.com>
Authored: Sun Sep 11 14:08:51 2016 -0500
Committer: Paul J. Davis <pa...@gmail.com>
Committed: Sun Sep 11 14:08:51 2016 -0500
----------------------------------------------------------------------
test/mango.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/couchdb-mango/blob/29b59449/test/mango.py
----------------------------------------------------------------------
diff --git a/test/mango.py b/test/mango.py
index 09c45fc..da51180 100644
--- a/test/mango.py
+++ b/test/mango.py
@@ -27,7 +27,7 @@ def random_db_name():
return "mango_test_" + uuid.uuid4().hex
def has_text_service():
- return os.path.isfile(os.getcwd() + "/../src/mango_cursor.erl")
+ return os.path.isfile(os.getcwd() + "/../src/mango_cursor_text.erl")
class Database(object):